From: Srish Srinivasan <ssrish@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, nayna@linux.ibm.com,
gjoyce@linux.ibm.com, ritesh.list@gmail.com,
sshegde@linux.ibm.com, linux-kernel@vger.kernel.org,
rnsastry@linux.ibm.com, ssrish@linux.ibm.com,
stable@vger.kernel.org
Subject: [PATCH 06/12] pseries/plpks: clear signed update authentication buffer
Date: Wed, 23 Sep 2026 23:58:10 +0530 [thread overview]
Message-ID: <20260923182816.151451-7-ssrish@linux.ibm.com> (raw)
In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com>
The PLPKS signed update operation uses an authentication buffer that
contains a password. Freeing this buffer with kfree(), without wiping
the contents, can leave sensitive data in memory.
Use kfree_sensitive() to wipe the buffer when freeing it.
Fixes: 899d9b8fee66 ("powerpc/pseries: Implement signed update for PLPKS objects")
Cc: stable@vger.kernel.org # 6.3
Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
Reviewed-by: Nayna Jain <nayna@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
---
arch/powerpc/platforms/pseries/plpks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
index 17a73a04d45b..b057e378a6b3 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -685,7 +685,7 @@ int plpks_signed_update_var(struct plpks_var *var, u64 flags)
kfree(label);
out:
- kfree(auth);
+ kfree_sensitive(auth);
return rc;
}
--
2.52.0
next prev parent reply other threads:[~2026-09-23 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:28 [PATCH 00/12] Refactor and harden PLPKS code Srish Srinivasan
2026-09-23 18:28 ` [PATCH 01/12] pseries/plpks: fix error handling in plpks_read_var() Srish Srinivasan
2026-09-23 18:28 ` [PATCH 02/12] pseries/plpks: fix error code for wrapping key reads Srish Srinivasan
2026-09-23 18:28 ` [PATCH 03/12] pseries/plpks: validate input to plpks_signed_update_var() Srish Srinivasan
2026-09-23 18:28 ` [PATCH 04/12] pseries/plpks: clear sensitive PLPKS buffers Srish Srinivasan
2026-09-23 18:28 ` [PATCH 05/12] pseries/plpks: clear sensitive buffers in wrapping operations Srish Srinivasan
2026-09-23 18:28 ` Srish Srinivasan [this message]
2026-09-23 18:28 ` [PATCH 07/12] pseries/plpks: clear SED key data after use Srish Srinivasan
2026-09-23 18:28 ` [PATCH 08/12] pseries/plpks: fix self-reference in plpks_var initializer Srish Srinivasan
2026-09-23 18:28 ` [PATCH 09/12] pseries/plpks: hide wrapping_features when unsupported Srish Srinivasan
2026-09-23 18:28 ` [PATCH 10/12] pseries/plpks: make narrowing conversions explicit Srish Srinivasan
2026-09-23 18:28 ` [PATCH 11/12] pseries/plpks: rename the default wrapping key macro Srish Srinivasan
2026-09-23 18:28 ` [PATCH 12/12] pseries/plpks: update PKS documentation and MAINTAINERS entry Srish Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923182816.151451-7-ssrish@linux.ibm.com \
--to=ssrish@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gjoyce@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=rnsastry@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®