mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<linux-kernel@vger.kernel.org>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
	<linux-ide@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix for storage corruption w/ AMD IOMMU on 64-bit addressing
Date: Wed, 23 Sep 2026 13:46:09 -0500	[thread overview]
Message-ID: <20260923184609.GA1906456@bhelgaas> (raw)
In-Reply-To: <52e6bb87-1a64-405b-a11a-3b9f9bf95410@amd.com>

On Wed, Sep 23, 2026 at 01:39:46PM -0500, Mario Limonciello wrote:
> On 9/23/26 13:36, Bjorn Helgaas wrote:
> > On Tue, Sep 08, 2026 at 02:05:58PM -0500, Mario Limonciello wrote:
> > > An issue has been reported by a number of people that corruption
> > > was occurring on storage for desktop systems.  It's notably reported
> > > on SATA, but the same issue also appears on NVME.
> > > 
> > > At a glance it looks like an IOMMU issue as turning off the IOMMU helps
> > > the issue, but it's actually a problem that occurs specifically with any
> > > IOVA addressed >58 bits.
> > > 
> > > This is because the BIOS on these systems is enabling a feature of the
> > > root port called 'enhanced atomics' which repurposes those upper 5 bits
> > > of address space.  That feature should only be enabled by the BIOS when
> > > the partner device supports it, but it's instead needlessly enabled on a
> > > number of root ports.
> > > 
> > > As some of these systems probably won't receive BIOS updates and there is
> > > active reports of data corruption root caused to this add a quirk to
> > > disable it on affected models, and also remove the quirk that was
> > > introduced to work around this issue in drivers/ata.
> > > 
> > > v2:
> > >   *  Added resume fixups for the affected AMD PCIe ports
> > > 
> > > Mario Limonciello (2):
> > >    x86/PCI: Disable enhanced atomics on some AMD PCIe ports
> > >    Revert "ata: ahci: force 32-bit DMA for JMicron JMB582/JMB585"
> > > 
> > >   arch/x86/pci/fixup.c | 99 ++++++++++++++++++++++++++++++++++++++++++++
> > >   drivers/ata/ahci.c   | 18 --------
> > >   2 files changed, 99 insertions(+), 18 deletions(-)
> > 
> > Applied to pci/for-linus for v7.3, thanks!
> 
> Thanks!  Could you add to the commits:
> 
> Cc: stable@vger.kernel.org
> 
> We should take this back to any non EoL kernel as well.

Done :)

      reply	other threads:[~2026-09-23 18:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 19:05 Mario Limonciello
2026-09-08 19:05 ` [PATCH v2 1/2] x86/PCI: Disable enhanced atomics on some AMD PCIe ports Mario Limonciello
2026-09-14 16:57   ` Mario Limonciello
2026-09-22 15:35     ` Mario Limonciello
2026-09-23 17:12   ` Bjorn Helgaas
2026-09-23 17:30     ` Mario Limonciello
2026-09-23 18:05       ` Bjorn Helgaas
2026-09-23 18:25         ` Mario Limonciello
2026-09-08 19:06 ` [PATCH v2 2/2] Revert "ata: ahci: force 32-bit DMA for JMicron JMB582/JMB585" Mario Limonciello
2026-09-22 12:52   ` Niklas Cassel
2026-09-21  4:52 ` [PATCH v2 0/2] Fix for storage corruption w/ AMD IOMMU on 64-bit addressing Mario Limonciello
2026-09-22  9:49   ` Niklas Cassel
2026-09-22 10:44     ` Mario Limonciello
2026-09-22 15:46   ` Mario Limonciello
2026-09-23 18:36 ` Bjorn Helgaas
2026-09-23 18:39   ` Mario Limonciello
2026-09-23 18:46     ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923184609.GA1906456@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=cassel@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dlemoal@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®