mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X
@ 2026-09-23 17:48 Nikolay Plastinin via B4 Relay
  2026-09-24  5:31 ` Николай Пластинин
  2026-10-05 18:52 ` Ilpo Järvinen
  0 siblings, 2 replies; 3+ messages in thread
From: Nikolay Plastinin via B4 Relay @ 2026-09-23 17:48 UTC (permalink / raw)
  To: Corentin Chary, Luke D. Jones, Denis Benato, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel, Nikolay Plastinin

From: Nikolay Plastinin <plaztininikolai@gmail.com>

The 2023 ROG Flow X13 (GV302X*) is a 360-degree convertible like the
GV301, but the existing "GV301" DMI entry does not match it, so the
driver does not register SW_TABLET_MODE and the desktop does not switch
to tablet mode when the screen is folded back.

With asus_nb_wmi.tablet_mode_sw=3 (lid-flip-rog) the "Asus WMI hotkeys"
input device reports SW_TABLET_MODE on every fold and unfold, so apply
quirk_asus_tablet_mode to GV302X* too. Apart from the tablet switch this
quirk is the same as quirk_asus_unknown, which these models get today.

DMI product name of the tested machine: "ROG Flow X13 GV302XV_GV302XV".

Tested on GV302XV.

Signed-off-by: Nikolay Plastinin <plaztininikolai@gmail.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index da1ddd601..3b0f3346d 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -503,6 +503,16 @@ static const struct dmi_system_id asus_quirks[] = {
 		},
 		.driver_data = &quirk_asus_tablet_mode,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "ASUS ROG FLOW X13",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			/* Match GV302X* */
+			DMI_MATCH(DMI_PRODUCT_NAME, "GV302X"),
+		},
+		.driver_data = &quirk_asus_tablet_mode,
+	},
 	{
 		.callback = dmi_matched,
 		.ident = "ASUS ROG FLOW X16",

---
base-commit: f475845eaf3d749114a63270bf2efea459e14dd2
change-id: 20260924-gv302-tablet-e27e313030c4

Best regards,
-- 
Nikolay Plastinin <plaztininikolai@gmail.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X
  2026-09-23 17:48 [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X Nikolay Plastinin via B4 Relay
@ 2026-09-24  5:31 ` Николай Пластинин
  2026-10-05 18:52 ` Ilpo Järvinen
  1 sibling, 0 replies; 3+ messages in thread
From: Николай Пластинин @ 2026-09-24  5:31 UTC (permalink / raw)
  To: plaztininikolai
  Cc: Corentin Chary, Luke D. Jones, Denis Benato, Hans de Goede,
	Ilpo Järvinen, platform-driver-x86, linux-kernel

чт, 24 сент. 2026 г. в 01:48, Nikolay Plastinin via B4 Relay
<devnull+plaztininikolai.gmail.com@kernel.org>:
This patch was prepared with the help of an AI assistant (Assisted-by: LLM);
I reviewed it and tested it on my GV302XV. Happy to resend with the tag
if preferred.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X
  2026-09-23 17:48 [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X Nikolay Plastinin via B4 Relay
  2026-09-24  5:31 ` Николай Пластинин
@ 2026-10-05 18:52 ` Ilpo Järvinen
  1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2026-10-05 18:52 UTC (permalink / raw)
  To: Corentin Chary, Luke D. Jones, Denis Benato, Hans de Goede,
	Nikolay Plastinin
  Cc: platform-driver-x86, linux-kernel

On Thu, 24 Sep 2026 01:48:02 +0800, Nikolay Plastinin wrote:

> The 2023 ROG Flow X13 (GV302X*) is a 360-degree convertible like the
> GV301, but the existing "GV301" DMI entry does not match it, so the
> driver does not register SW_TABLET_MODE and the desktop does not switch
> to tablet mode when the screen is folded back.
> 
> With asus_nb_wmi.tablet_mode_sw=3 (lid-flip-rog) the "Asus WMI hotkeys"
> input device reports SW_TABLET_MODE on every fold and unfold, so apply
> quirk_asus_tablet_mode to GV302X* too. Apart from the tablet switch this
> quirk is the same as quirk_asus_unknown, which these models get today.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X
      commit: 2622c23b7b640476a06d767b6ae63315ba5993a8

--
 i.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-05 18:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23 17:48 [PATCH] platform/x86: asus-nb-wmi: add tablet mode quirk for ROG Flow X13 GV302X Nikolay Plastinin via B4 Relay
2026-09-24  5:31 ` Николай Пластинин
2026-10-05 18:52 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®