* [PATCH v2] PCI: rcar: Release temporary device tree node reference
@ 2026-09-24 1:04 Yuho Choi
0 siblings, 0 replies; only message in thread
From: Yuho Choi @ 2026-09-24 1:04 UTC (permalink / raw)
To: Marek Vasut, Manivannan Sadhasivam, Yoshihiro Shimoda
Cc: Geert Uytterhoeven, Rob Herring, Bjorn Helgaas,
Lorenzo Pieralisi, Krzysztof Wilczyński, linux-pci,
linux-renesas-soc, linux-kernel, Yuho Choi
of_find_matching_node() returns a referenced node even when it is used
only as a boolean test. Drop the reference right after the match check.
Fixes: a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook")
Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
---
Changes in v2:
- Use an explicit of_node_put() instead of __free(device_node) (Marek Vasut)
- Switch to my oss.patchbox address
v1: https://lore.kernel.org/all/20260801233841.469826-1-dbgh9129@gmail.com/
drivers/pci/controller/pcie-rcar-host.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index cd9171eebc289..1f5e33c802b5b 100644
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -1122,7 +1122,11 @@ static const struct of_device_id rcar_pcie_abort_handler_of_match[] __initconst
static int __init rcar_pcie_init(void)
{
- if (of_find_matching_node(NULL, rcar_pcie_abort_handler_of_match)) {
+ struct device_node *np;
+
+ np = of_find_matching_node(NULL, rcar_pcie_abort_handler_of_match);
+ if (np) {
+ of_node_put(np);
#ifdef CONFIG_ARM_LPAE
hook_fault_code(17, rcar_pcie_aarch32_abort_handler, SIGBUS, 0,
"asynchronous external abort");
base-commit: f0100363d8c374bd8e9ea7c9ba02744f0b802ca4
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-24 1:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-24 1:04 [PATCH v2] PCI: rcar: Release temporary device tree node reference Yuho Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®