* [PATCH] speakup: Drop now-unused serialio operations
@ 2026-09-22 6:30 Samuel Thibault
2026-09-23 22:48 ` kernel test robot
2026-09-23 23:38 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Thibault @ 2026-09-22 6:30 UTC (permalink / raw)
To: gregkh; +Cc: Samuel Thibault, w.d.hubbs, chris, kirk, speakup, linux-kernel
The only users of serialio (acntpc, decpc, dtlk, keypc) don't actually
define a read_buff_add method, so start_stop_serial_interrupt were not doing
anything. The other functions were not referenced at all any more since
bbe6fb5b96bd ("staging: speakup: migrate bns to tty")
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
drivers/accessibility/speakup/serialio.c | 179 ------------------
.../accessibility/speakup/speakup_acntpc.c | 1 -
drivers/accessibility/speakup/speakup_decpc.c | 1 -
drivers/accessibility/speakup/speakup_dtlk.c | 1 -
drivers/accessibility/speakup/speakup_keypc.c | 1 -
drivers/accessibility/speakup/spk_priv.h | 6 -
6 files changed, 189 deletions(-)
diff --git a/drivers/accessibility/speakup/serialio.c b/drivers/accessibility/speakup/serialio.c
index 3418ea31d28f..b8d89dc30704 100644
--- a/drivers/accessibility/speakup/serialio.c
+++ b/drivers/accessibility/speakup/serialio.c
@@ -17,8 +17,6 @@
#define SERIAL_PORT_DFNS
#endif
-static void start_serial_interrupt(int irq);
-
static const struct old_serial_port rs_table[] = {
SERIAL_PORT_DFNS
};
@@ -45,111 +43,6 @@ struct spk_io_ops spk_serial_io_ops = {
};
EXPORT_SYMBOL_GPL(spk_serial_io_ops);
-const struct old_serial_port *spk_serial_init(int index)
-{
- int baud = 9600, quot = 0;
- unsigned int cval = 0;
- int cflag = CREAD | HUPCL | CLOCAL | B9600 | CS8;
- const struct old_serial_port *ser;
- int err;
-
- if (index >= ARRAY_SIZE(rs_table)) {
- pr_info("no port info for ttyS%d\n", index);
- return NULL;
- }
- ser = rs_table + index;
-
- /* Divisor, byte size and parity */
- quot = ser->baud_base / baud;
- cval = cflag & (CSIZE | CSTOPB);
-#if defined(__powerpc__) || defined(__alpha__)
- cval >>= 8;
-#else /* !__powerpc__ && !__alpha__ */
- cval >>= 4;
-#endif /* !__powerpc__ && !__alpha__ */
- if (cflag & PARENB)
- cval |= UART_LCR_PARITY;
- if (!(cflag & PARODD))
- cval |= UART_LCR_EPAR;
- if (synth_request_region(ser->port, 8)) {
- /* try to take it back. */
- pr_info("Ports not available, trying to steal them\n");
- __release_region(&ioport_resource, ser->port, 8);
- err = synth_request_region(ser->port, 8);
- if (err) {
- pr_warn("Unable to allocate port at %x, errno %i",
- ser->port, err);
- return NULL;
- }
- }
-
- /* Disable UART interrupts, set DTR and RTS high
- * and set speed.
- */
- outb(cval | UART_LCR_DLAB, ser->port + UART_LCR); /* set DLAB */
- outb(quot & 0xff, ser->port + UART_DLL); /* LS of divisor */
- outb(quot >> 8, ser->port + UART_DLM); /* MS of divisor */
- outb(cval, ser->port + UART_LCR); /* reset DLAB */
-
- /* Turn off Interrupts */
- outb(0, ser->port + UART_IER);
- outb(UART_MCR_DTR | UART_MCR_RTS, ser->port + UART_MCR);
-
- /* If we read 0xff from the LSR, there is no UART here. */
- if (inb(ser->port + UART_LSR) == 0xff) {
- synth_release_region(ser->port, 8);
- serstate = NULL;
- return NULL;
- }
-
- mdelay(1);
- speakup_info.port_tts = ser->port;
- serstate = ser;
-
- start_serial_interrupt(ser->irq);
-
- return ser;
-}
-
-static irqreturn_t synth_readbuf_handler(int irq, void *dev_id)
-{
- unsigned long flags;
- int c;
-
- spin_lock_irqsave(&speakup_info.spinlock, flags);
- while (inb_p(speakup_info.port_tts + UART_LSR) & UART_LSR_DR) {
- c = inb_p(speakup_info.port_tts + UART_RX);
- synth->read_buff_add((u_char)c);
- }
- spin_unlock_irqrestore(&speakup_info.spinlock, flags);
- return IRQ_HANDLED;
-}
-
-static void start_serial_interrupt(int irq)
-{
- int rv;
-
- if (!synth->read_buff_add)
- return;
-
- rv = request_irq(irq, synth_readbuf_handler, IRQF_SHARED,
- "serial", (void *)synth_readbuf_handler);
-
- if (rv)
- pr_err("Unable to request Speakup serial I R Q\n");
- /* Set MCR */
- outb(UART_MCR_DTR | UART_MCR_RTS | UART_MCR_OUT2,
- speakup_info.port_tts + UART_MCR);
- /* Turn on Interrupts */
- outb(UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI,
- speakup_info.port_tts + UART_IER);
- inb(speakup_info.port_tts + UART_LSR);
- inb(speakup_info.port_tts + UART_RX);
- inb(speakup_info.port_tts + UART_IIR);
- inb(speakup_info.port_tts + UART_MSR);
- outb(1, speakup_info.port_tts + UART_FCR); /* Turn FIFO On */
-}
-
static void spk_serial_send_xchar(struct spk_synth *synth, char ch)
{
int timeout = SPK_XMITR_TIMEOUT;
@@ -169,50 +62,6 @@ static void spk_serial_tiocmset(struct spk_synth *in_synth, unsigned int set, un
outb((old & ~clear) | set, speakup_info.port_tts + UART_MCR);
}
-int spk_serial_synth_probe(struct spk_synth *synth)
-{
- const struct old_serial_port *ser;
- int failed = 0;
-
- if ((synth->ser >= SPK_LO_TTY) && (synth->ser <= SPK_HI_TTY)) {
- ser = spk_serial_init(synth->ser);
- if (!ser) {
- failed = -1;
- } else {
- outb_p(0, ser->port);
- mdelay(1);
- outb_p('\r', ser->port);
- }
- } else {
- failed = -1;
- pr_warn("ttyS%i is an invalid port\n", synth->ser);
- }
- if (failed) {
- pr_info("%s: not found\n", synth->long_name);
- return -ENODEV;
- }
- pr_info("%s: ttyS%i, Driver Version %s\n",
- synth->long_name, synth->ser, synth->version);
- synth->alive = 1;
- return 0;
-}
-EXPORT_SYMBOL_GPL(spk_serial_synth_probe);
-
-void spk_stop_serial_interrupt(void)
-{
- if (speakup_info.port_tts == 0)
- return;
-
- if (!synth->read_buff_add)
- return;
-
- /* Turn off interrupts */
- outb(0, speakup_info.port_tts + UART_IER);
- /* Free IRQ */
- free_irq(serstate->irq, (void *)synth_readbuf_handler);
-}
-EXPORT_SYMBOL_GPL(spk_stop_serial_interrupt);
-
static int spk_serial_wait_for_xmitr(struct spk_synth *in_synth)
{
int tmout = SPK_XMITR_TIMEOUT;
@@ -288,31 +137,3 @@ static int spk_serial_out(struct spk_synth *in_synth, const char ch)
}
return 0;
}
-
-const char *spk_serial_synth_immediate(struct spk_synth *synth,
- const char *buff)
-{
- u_char ch;
-
- while ((ch = *buff)) {
- if (ch == '\n')
- ch = synth->procspeech;
- if (spk_serial_wait_for_xmitr(synth))
- outb(ch, speakup_info.port_tts);
- else
- return buff;
- buff++;
- }
- return NULL;
-}
-EXPORT_SYMBOL_GPL(spk_serial_synth_immediate);
-
-void spk_serial_release(struct spk_synth *synth)
-{
- spk_stop_serial_interrupt();
- if (speakup_info.port_tts == 0)
- return;
- synth_release_region(speakup_info.port_tts, 8);
- speakup_info.port_tts = 0;
-}
-EXPORT_SYMBOL_GPL(spk_serial_release);
diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c
index a27e6bbf05da..1cc6147cafac 100644
--- a/drivers/accessibility/speakup/speakup_acntpc.c
+++ b/drivers/accessibility/speakup/speakup_acntpc.c
@@ -305,7 +305,6 @@ static int synth_probe(struct spk_synth *synth)
static void accent_release(struct spk_synth *synth)
{
- spk_stop_serial_interrupt();
if (speakup_info.port_tts)
synth_release_region(speakup_info.port_tts - 1,
SYNTH_IO_EXTENT);
diff --git a/drivers/accessibility/speakup/speakup_decpc.c b/drivers/accessibility/speakup/speakup_decpc.c
index 1bf36d1e5477..4837cac8bafa 100644
--- a/drivers/accessibility/speakup/speakup_decpc.c
+++ b/drivers/accessibility/speakup/speakup_decpc.c
@@ -487,7 +487,6 @@ static int synth_probe(struct spk_synth *synth)
static void dtpc_release(struct spk_synth *synth)
{
- spk_stop_serial_interrupt();
if (speakup_info.port_tts)
synth_release_region(speakup_info.port_tts, SYNTH_IO_EXTENT);
speakup_info.port_tts = 0;
diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c
index fa826568937b..0a57f7ea894c 100644
--- a/drivers/accessibility/speakup/speakup_dtlk.c
+++ b/drivers/accessibility/speakup/speakup_dtlk.c
@@ -377,7 +377,6 @@ static int synth_probe(struct spk_synth *synth)
static void dtlk_release(struct spk_synth *synth)
{
- spk_stop_serial_interrupt();
if (speakup_info.port_tts)
synth_release_region(speakup_info.port_tts - 1,
SYNTH_IO_EXTENT);
diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
index 9356f6379560..1e2edc5c4b8b 100644
--- a/drivers/accessibility/speakup/speakup_keypc.c
+++ b/drivers/accessibility/speakup/speakup_keypc.c
@@ -306,7 +306,6 @@ static int synth_probe(struct spk_synth *synth)
static void keynote_release(struct spk_synth *synth)
{
- spk_stop_serial_interrupt();
if (synth_port)
synth_release_region(synth_port, SYNTH_IO_EXTENT);
synth_port = 0;
diff --git a/drivers/accessibility/speakup/spk_priv.h b/drivers/accessibility/speakup/spk_priv.h
index 9da57ead17cb..704ff9f120d3 100644
--- a/drivers/accessibility/speakup/spk_priv.h
+++ b/drivers/accessibility/speakup/spk_priv.h
@@ -32,9 +32,6 @@
#define SYNTH_DEFAULT_DEV "ttyS0"
#define SYNTH_DEFAULT_SER 0
-const struct old_serial_port *spk_serial_init(int index);
-void spk_stop_serial_interrupt(void);
-void spk_serial_release(struct spk_synth *synth);
void spk_ttyio_release(struct spk_synth *synth);
void spk_ttyio_register_ldisc(void);
void spk_ttyio_unregister_ldisc(void);
@@ -49,10 +46,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
const char *buf, size_t count);
-int spk_serial_synth_probe(struct spk_synth *synth);
int spk_ttyio_synth_probe(struct spk_synth *synth);
-const char *spk_serial_synth_immediate(struct spk_synth *synth,
- const char *buff);
const char *spk_ttyio_synth_immediate(struct spk_synth *synth,
const char *buff);
void spk_do_catch_up(struct spk_synth *synth);
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: Drop now-unused serialio operations
2026-09-22 6:30 [PATCH] speakup: Drop now-unused serialio operations Samuel Thibault
@ 2026-09-23 22:48 ` kernel test robot
2026-09-23 23:38 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-09-23 22:48 UTC (permalink / raw)
To: Samuel Thibault, gregkh
Cc: oe-kbuild-all, Samuel Thibault, w.d.hubbs, chris, kirk, speakup,
linux-kernel
Hi Samuel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus linus/master v7.3-rc4 next-20260922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Thibault/speakup-Drop-now-unused-serialio-operations/20260922-083047
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260922063047.1392828-1-samuel.thibault%40ens-lyon.org
patch subject: [PATCH] speakup: Drop now-unused serialio operations
config: powerpc-randconfig-1000-20260924 (https://download.01.org/0day-ci/archive/20260924/202609240615.5JumpThZ-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260924/202609240615.5JumpThZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609240615.5JumpThZ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/accessibility/speakup/serialio.c:24:38: warning: 'serstate' defined but not used [-Wunused-variable]
static const struct old_serial_port *serstate;
^~~~~~~~
>> drivers/accessibility/speakup/serialio.c:20:37: warning: 'rs_table' defined but not used [-Wunused-const-variable=]
static const struct old_serial_port rs_table[] = {
^~~~~~~~
vim +/serstate +24 drivers/accessibility/speakup/serialio.c
5e6dc548e453c6 drivers/staging/speakup/serialio.c Chen Gang 2013-10-31 19
3ee0017e03cd79 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 @20 static const struct old_serial_port rs_table[] = {
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 21 SERIAL_PORT_DFNS
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 22 };
defaa9ad58dfc5 drivers/staging/speakup/serialio.c Arushi Singhal 2017-03-14 23
3ee0017e03cd79 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 @24 static const struct old_serial_port *serstate;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 25 static int timeouts;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 26
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: Drop now-unused serialio operations
2026-09-22 6:30 [PATCH] speakup: Drop now-unused serialio operations Samuel Thibault
2026-09-23 22:48 ` kernel test robot
@ 2026-09-23 23:38 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-09-23 23:38 UTC (permalink / raw)
To: Samuel Thibault, gregkh
Cc: llvm, oe-kbuild-all, Samuel Thibault, w.d.hubbs, chris, kirk,
speakup, linux-kernel
Hi Samuel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus linus/master v7.3-rc4 next-20260922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Thibault/speakup-Drop-now-unused-serialio-operations/20260922-083047
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260922063047.1392828-1-samuel.thibault%40ens-lyon.org
patch subject: [PATCH] speakup: Drop now-unused serialio operations
config: arm-randconfig-1002-20260924 (https://download.01.org/0day-ci/archive/20260924/202609240754.Q7KcTPuv-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260924/202609240754.Q7KcTPuv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609240754.Q7KcTPuv-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/accessibility/speakup/serialio.c:20:37: warning: unused variable 'rs_table' [-Wunused-const-variable]
20 | static const struct old_serial_port rs_table[] = {
| ^~~~~~~~
>> drivers/accessibility/speakup/serialio.c:24:38: warning: unused variable 'serstate' [-Wunused-variable]
24 | static const struct old_serial_port *serstate;
| ^~~~~~~~
2 warnings generated.
vim +/rs_table +20 drivers/accessibility/speakup/serialio.c
5e6dc548e453c68 drivers/staging/speakup/serialio.c Chen Gang 2013-10-31 19
3ee0017e03cd790 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 @20 static const struct old_serial_port rs_table[] = {
c6e3fd22cd53836 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 21 SERIAL_PORT_DFNS
c6e3fd22cd53836 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 22 };
defaa9ad58dfc56 drivers/staging/speakup/serialio.c Arushi Singhal 2017-03-14 23
3ee0017e03cd790 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 @24 static const struct old_serial_port *serstate;
c6e3fd22cd53836 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 25 static int timeouts;
c6e3fd22cd53836 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 26
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-23 23:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-22 6:30 [PATCH] speakup: Drop now-unused serialio operations Samuel Thibault
2026-09-23 22:48 ` kernel test robot
2026-09-23 23:38 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®