From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: "Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"David E Box" <david.e.box@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 11/19] platform/x86/intel/tpmi: Include the headers tpmi_common.c relies on
Date: Thu, 24 Sep 2026 11:23:33 -0700 [thread overview]
Message-ID: <20260924182342.212709-12-sathyanarayanan.kuppuswamy@linux.intel.com> (raw)
In-Reply-To: <20260924182342.212709-1-sathyanarayanan.kuppuswamy@linux.intel.com>
tpmi_common.c uses a number of interfaces whose headers it never includes
directly and only gets by chance through other headers:
BIT_ULL(), GENMASK_ULL() bits.h
__packed compiler_attributes.h
EXPORT_SYMBOL_NS_GPL() export.h
DEFINE_IDA() idr.h
IORESOURCE_MEM ioport.h
DEFINE_MUTEX(), mutex_lock() mutex.h
seq_printf(), seq_hex_dump() seq_file.h
kmalloc(), kzalloc_flex() slab.h
USEC_PER_MSEC, USEC_PER_SEC time64.h
uXX types.h
Include them, so that the file does not break when an unrelated header
stops pulling them in.
Drop io.h while at it, as iopoll.h already includes it, and sort the
block alphabetically: debugfs.h and cleanup.h were the wrong way round.
No functional change intended.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
drivers/platform/x86/intel/tpmi_common.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/tpmi_common.c b/drivers/platform/x86/intel/tpmi_common.c
index 0db766309529..83362d4bb726 100644
--- a/drivers/platform/x86/intel/tpmi_common.c
+++ b/drivers/platform/x86/intel/tpmi_common.c
@@ -32,19 +32,28 @@
#include <linux/array_size.h>
#include <linux/auxiliary_bus.h>
#include <linux/bitfield.h>
-#include <linux/debugfs.h>
+#include <linux/bits.h>
#include <linux/cleanup.h>
+#include <linux/compiler_attributes.h>
+#include <linux/debugfs.h>
#include <linux/delay.h>
+#include <linux/export.h>
+#include <linux/idr.h>
#include <linux/intel_tpmi.h>
#include <linux/intel_vsec.h>
-#include <linux/io.h>
#include <linux/iopoll.h>
+#include <linux/ioport.h>
#include <linux/module.h>
+#include <linux/mutex.h>
#include <linux/notifier.h>
#include <linux/pci.h>
#include <linux/security.h>
+#include <linux/seq_file.h>
#include <linux/sizes.h>
+#include <linux/slab.h>
#include <linux/string_helpers.h>
+#include <linux/time64.h>
+#include <linux/types.h>
#include "tpmi_common.h"
--
2.43.0
next prev parent reply other threads:[~2026-09-24 18:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 18:23 [PATCH v2 00/19] Decouple PCI and auxbus details from Intel TPMI driver Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 01/19] platform/x86/intel/tpmi: Use static strings for the feature device names Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 02/19] platform/x86/intel/vsec: Pass a struct device to intel_vsec_set_mapping() Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 03/19] platform/x86/intel/tpmi: Remove unused vsec_dev from intel_tpmi_pm_feature Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 04/19] platform/x86/intel/tpmi: Get tpmi_info directly from the parent device Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 05/19] platform/x86/intel/tpmi: Keep the feature resources in intel_tpmi_info Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 06/19] platform/x86/intel/tpmi: Describe a TPMI instance by its two devices Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 07/19] platform/x86/intel/tpmi: Drop unused arg from tpmi_set_control_base() Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 08/19] platform/x86/intel/tpmi: Do not assume TPMI is enumerated from PCI Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 09/19] platform/x86/intel/tpmi: Split out enumeration independent init and exit Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 10/19] platform/x86/intel/tpmi: Split off the PCI VSEC enumeration Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` Kuppuswamy Sathyanarayanan [this message]
2026-09-24 21:10 ` [PATCH v2 11/19] platform/x86/intel/tpmi: Include the headers tpmi_common.c relies on Andy Shevchenko
2026-09-24 18:23 ` [PATCH v2 12/19] platform/x86/intel/tpmi: Turn TPMI_GET_SINGLE_ENTRY_SIZE() into a function Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 13/19] platform/x86/intel/tpmi: Use guard() for tpmi_dev_lock in the status read Kuppuswamy Sathyanarayanan
2026-09-24 21:15 ` Andy Shevchenko
2026-09-24 18:23 ` [PATCH v2 14/19] platform/x86/intel/tpmi: Use scope based cleanup in the memory dump Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 15/19] platform/x86/intel/tpmi: Build the TPMI control words in one expression Kuppuswamy Sathyanarayanan
2026-09-24 21:14 ` Andy Shevchenko
2026-09-24 18:23 ` [PATCH v2 16/19] platform/x86/intel/tpmi: Use DEFINE_SHOW_STORE_ATTRIBUTE() for mem_write Kuppuswamy Sathyanarayanan
2026-09-24 21:14 ` Andy Shevchenko
2026-09-24 18:23 ` [PATCH v2 17/19] platform/x86/intel/tpmi: Use scnprintf() to build the debugfs names Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 18/19] platform/x86/intel/tpmi: Declare the loop counters in their loops Kuppuswamy Sathyanarayanan
2026-09-24 21:17 ` Andy Shevchenko
2026-09-25 17:55 ` Kuppuswamy Sathyanarayanan
2026-09-24 18:23 ` [PATCH v2 19/19] platform/x86/intel/tpmi: Describe the device creation policy on the function Kuppuswamy Sathyanarayanan
2026-09-24 21:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924182342.212709-12-sathyanarayanan.kuppuswamy@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®