From: Melissa Wen <mwen@igalia.com>
To: airlied@gmail.com, alexander.deucher@amd.com,
aurabindo.pillai@amd.com, Aurabindo.Pillai@amd.com,
christian.koenig@amd.com, David.Francis@amd.com,
harry.wentland@amd.com, simona@ffwll.ch, siqueira@igalia.com,
sunpeng.li@amd.com
Cc: amd-gfx@lists.freedesktop.org, Harry.Wentland@amd.com,
kernel-dev@igalia.com, linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] drm/amd/display: use right type for amdgpu_dc_performance event entries
Date: Thu, 24 Sep 2026 23:10:08 +0200 [thread overview]
Message-ID: <20260924211410.867686-6-mwen@igalia.com> (raw)
In-Reply-To: <20260924211410.867686-1-mwen@igalia.com>
Some amdgpu_dc_performance trace event params are passed as unsigned
long but stored as uint32_t, cutting them off on 64-bit. Use the right
type on entry fields and on printk use unsigned format accordingly.
Fixes: 0cf5eb76e2b4 ("drm/amd/display: Add tracing to dc")
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
index c59ba41a9721..26c85d95bcc0 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
@@ -76,10 +76,10 @@ TRACE_EVENT(amdgpu_dc_performance,
const char *func, unsigned int line),
TP_ARGS(read_count, write_count, last_read, last_write, func, line),
TP_STRUCT__entry(
- __field(uint32_t, reads)
- __field(uint32_t, writes)
- __field(uint32_t, read_delta)
- __field(uint32_t, write_delta)
+ __field(unsigned long, reads)
+ __field(unsigned long, writes)
+ __field(unsigned long, read_delta)
+ __field(unsigned long, write_delta)
__string(func, func)
__field(uint32_t, line)
),
@@ -93,12 +93,9 @@ TRACE_EVENT(amdgpu_dc_performance,
*last_read = read_count;
*last_write = write_count;
),
- TP_printk("%s:%d reads=%08ld (%08ld total), writes=%08ld (%08ld total)",
- __get_str(func), __entry->line,
- (unsigned long)__entry->read_delta,
- (unsigned long)__entry->reads,
- (unsigned long)__entry->write_delta,
- (unsigned long)__entry->writes)
+ TP_printk("%s:%u reads=%08lu (%08lu total), writes=%08lu (%08lu total)",
+ __get_str(func), __entry->line, __entry->read_delta,
+ __entry->reads, __entry->write_delta, __entry->writes)
);
TRACE_EVENT(amdgpu_dm_connector_atomic_check,
--
2.53.0
next prev parent reply other threads:[~2026-09-24 21:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 21:10 [PATCH 0/8] drm/amd/display: DM trace event cleanups Melissa Wen
2026-09-24 21:10 ` [PATCH 1/8] drm/amd/display: assign missing trace entry in amdgpu_dm_dc_clocks_state Melissa Wen
2026-09-25 9:45 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 2/8] drm/amd/display: remove duplicated prev_p_state_change_support assignment Melissa Wen
2026-09-25 9:45 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 3/8] drm/amd/display: fix vready offset assignment in dcn_optc_lock_unlock_state Melissa Wen
2026-09-25 9:47 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 4/8] drm/amd/display: declare amdgpu_dm_atomic_state_template as an event class Melissa Wen
2026-09-25 9:55 ` Tvrtko Ursulin
2026-09-24 21:10 ` Melissa Wen [this message]
2026-09-25 10:03 ` [PATCH 5/8] drm/amd/display: use right type for amdgpu_dc_performance event entries Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 6/8] drm/amd/display: remove redundant cast on amdgpu_dc_reg_template printk Melissa Wen
2026-09-25 10:05 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 7/8] drm/amd/display: copy function name into dcn_fpu trace event Melissa Wen
2026-09-25 10:17 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 8/8] drm/amd/display: copy function name into dcn_optc_lock_unlock_state " Melissa Wen
2026-09-25 10:23 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924211410.867686-6-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=David.Francis@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®