From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: Melissa Wen <mwen@igalia.com>,
airlied@gmail.com, alexander.deucher@amd.com,
aurabindo.pillai@amd.com, christian.koenig@amd.com,
David.Francis@amd.com, harry.wentland@amd.com, simona@ffwll.ch,
siqueira@igalia.com, sunpeng.li@amd.com
Cc: amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] drm/amd/display: remove duplicated prev_p_state_change_support assignment
Date: Fri, 25 Sep 2026 10:45:37 +0100 [thread overview]
Message-ID: <4e7f1494-722b-4a09-9b8a-b26e879be2fa@igalia.com> (raw)
In-Reply-To: <20260924211410.867686-3-mwen@igalia.com>
On 24/09/2026 22:10, Melissa Wen wrote:
> The prev_p_state_change_support trace entry is assigned and printed
> twice, remove the unnecessary duplicates.
>
> Fixes: 13b5ca42ca9c ("drm/amd/display: Add tracepoint for capturing clocks state")
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> index cc70aeb75798..887ebac8c97e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> @@ -523,7 +523,6 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
> __entry->p_state_change_support = clk->p_state_change_support;
> __entry->prev_p_state_change_support = clk->prev_p_state_change_support;
> __entry->pwr_state = clk->pwr_state;
> - __entry->prev_p_state_change_support = clk->prev_p_state_change_support;
> __entry->dtm_level = clk->dtm_level;
> __entry->max_supported_dppclk_khz = clk->max_supported_dppclk_khz;
> __entry->max_supported_dispclk_khz = clk->max_supported_dispclk_khz;
> @@ -533,8 +532,8 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
> TP_printk("dispclk_khz=%d dppclk_khz=%d disp_dpp_voltage_level_khz=%d dcfclk_khz=%d socclk_khz=%d "
> "dcfclk_deep_sleep_khz=%d fclk_khz=%d phyclk_khz=%d "
> "dramclk_khz=%d p_state_change_support=%d "
> - "prev_p_state_change_support=%d pwr_state=%d prev_p_state_change_support=%d "
> - "dtm_level=%d max_supported_dppclk_khz=%d max_supported_dispclk_khz=%d "
> + "prev_p_state_change_support=%d pwr_state=%d dtm_level=%d "
> + "max_supported_dppclk_khz=%d max_supported_dispclk_khz=%d "
> "bw_dppclk_khz=%d bw_dispclk_khz=%d ",
> __entry->dispclk_khz,
> __entry->dppclk_khz,
> @@ -548,7 +547,6 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
> __entry->p_state_change_support,
> __entry->prev_p_state_change_support,
> __entry->pwr_state,
> - __entry->prev_p_state_change_support,
> __entry->dtm_level,
> __entry->max_supported_dppclk_khz,
> __entry->max_supported_dispclk_khz,
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Regards,
Tvrtko
next prev parent reply other threads:[~2026-09-25 9:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 21:10 [PATCH 0/8] drm/amd/display: DM trace event cleanups Melissa Wen
2026-09-24 21:10 ` [PATCH 1/8] drm/amd/display: assign missing trace entry in amdgpu_dm_dc_clocks_state Melissa Wen
2026-09-25 9:45 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 2/8] drm/amd/display: remove duplicated prev_p_state_change_support assignment Melissa Wen
2026-09-25 9:45 ` Tvrtko Ursulin [this message]
2026-09-24 21:10 ` [PATCH 3/8] drm/amd/display: fix vready offset assignment in dcn_optc_lock_unlock_state Melissa Wen
2026-09-25 9:47 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 4/8] drm/amd/display: declare amdgpu_dm_atomic_state_template as an event class Melissa Wen
2026-09-25 9:55 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 5/8] drm/amd/display: use right type for amdgpu_dc_performance event entries Melissa Wen
2026-09-25 10:03 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 6/8] drm/amd/display: remove redundant cast on amdgpu_dc_reg_template printk Melissa Wen
2026-09-25 10:05 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 7/8] drm/amd/display: copy function name into dcn_fpu trace event Melissa Wen
2026-09-25 10:17 ` Tvrtko Ursulin
2026-09-24 21:10 ` [PATCH 8/8] drm/amd/display: copy function name into dcn_optc_lock_unlock_state " Melissa Wen
2026-09-25 10:23 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7f1494-722b-4a09-9b8a-b26e879be2fa@igalia.com \
--to=tvrtko.ursulin@igalia.com \
--cc=David.Francis@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwen@igalia.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®