From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: Kiryl Shutsemau <kirill@shutemov.name>
Cc: Donggeun Yoo <donggeunyoo.kernel@gmail.com>,
akpm@linux-foundation.org, rppt@kernel.org, peterx@redhat.com,
surenb@google.com, aarcange@redhat.com, david@kernel.org,
ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
mhocko@suse.com, shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] userfaultfd: clear the inherited uffd bit in move_swap_pte()
Date: Fri, 25 Sep 2026 13:37:29 +0900 [thread overview]
Message-ID: <20260925043729.2362287-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <arO0a3CU_idyVsqQ@thinkstation>
On Wed, Sep 23, 2026 at 12:18:30PM +0100, Kiryl Shutsemau wrote:
> Putting it in the 'else' is wrong. Clear uffd on the source
> unconditionally and re-arm based on the target VMA:
>
> orig_src_pte = pte_swp_clear_uffd(orig_src_pte);
> /* Re-arm RWP on the moved swap entry if dst_vma is RWP-registered. */
> if (userfaultfd_rwp(dst_vma))
> orig_src_pte = pte_swp_mkuffd(orig_src_pte);
>
> That is what move_pages_huge_pmd() does with clear_uffd_wp_pmd() before
> its own re-arm, and it is the logically correct way to do this: the
> source's state is gone, the destination decides.
Done in v2:
https://lore.kernel.org/all/20260925042907.2330519-1-donggeunyoo.kernel@gmail.com/
Thanks,
Donggeun
next prev parent reply other threads:[~2026-09-25 4:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 0:46 [PATCH v1 0/2] " Donggeun Yoo
2026-09-19 0:46 ` [PATCH v1 1/2] " Donggeun Yoo
2026-09-22 6:45 ` Mike Rapoport
2026-09-22 12:47 ` Donggeun Yoo
2026-09-22 11:40 ` David Hildenbrand (Arm)
2026-09-22 12:41 ` Donggeun Yoo
2026-09-22 16:45 ` Mike Rapoport
2026-09-23 11:20 ` Kiryl Shutsemau
2026-09-23 11:18 ` Kiryl Shutsemau
2026-09-25 4:37 ` Donggeun Yoo [this message]
2026-09-25 7:01 ` David Hildenbrand (Arm)
2026-09-25 8:47 ` Kiryl Shutsemau
2026-09-19 0:46 ` [PATCH v1 2/2] selftests/mm: add a test for UFFDIO_MOVE of a write-protected swap entry Donggeun Yoo
2026-09-22 5:58 ` [PATCH v1 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925043729.2362287-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=kirill@shutemov.name \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®