From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@arkamax.eu>
Cc: "Ing. Alfonso Kuen Arroyo" <gerencia@idkmanager.com>,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA
Date: Fri, 25 Sep 2026 08:57:14 +0200 [thread overview]
Message-ID: <20260925065714.GA4457@lst.de> (raw)
In-Reply-To: <DLMIXHATYR90.4RUG08AMWH8U@arkamax.eu>
On Wed, Sep 23, 2026 at 09:39:59AM +0200, Maurizio Lombardi wrote:
> On Wed Sep 23, 2026 at 6:20 AM CEST, Ing. Alfonso Kuen Arroyo wrote:
> > The constant is 0x400000, 4 MiB, but the comment next to it said 16M.
> > Use SZ_4M instead of a value and a comment that can drift out of sync
> > with each other, as suggested by Christoph Hellwig.
> >
> > Noticed by Maurizio Lombardi while reviewing "nvmet-tcp: report a
> > bounded MDTS instead of "no limit"".
> >
> > v2: use SZ_4M instead of the raw hex value + comment (Christoph
> > Hellwig). The file did not pull in linux/sizes.h yet and had no
> > other SZ_ user, so the include is added.
>
> version differences should be put after the '---' separator, they are
> not part of the commit message
>
> >
> > Signed-off-by: Alfonso Kuen
>
> The mail is missing, this should be:
> Signed-off-by: Alfonso Kuen <gerencia@idkmanager.com>
Agreed on both. Otherwise this looks great, thanks.
prev parent reply other threads:[~2026-09-25 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 4:20 Ing. Alfonso Kuen Arroyo
2026-09-23 7:39 ` Maurizio Lombardi
2026-09-25 6:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925065714.GA4457@lst.de \
--to=hch@lst.de \
--cc=gerencia@idkmanager.com \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®