[PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA

[PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA

[Ing. Alfonso Kuen Arroyo]

The constant is 0x400000, 4 MiB, but the comment next to it said 16M.
Use SZ_4M instead of a value and a comment that can drift out of sync
with each other, as suggested by Christoph Hellwig.

Noticed by Maurizio Lombardi while reviewing "nvmet-tcp: report a
bounded MDTS instead of "no limit"".

v2: use SZ_4M instead of the raw hex value + comment (Christoph
    Hellwig). The file did not pull in linux/sizes.h yet and had no
    other SZ_ user, so the include is added.

Signed-off-by: Alfonso Kuen
---
 drivers/nvme/target/tcp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index e598101..000000 100644
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -18,12 +18,13 @@
 #include <net/handshake.h>
 #include <linux/inet.h>
 #include <linux/llist.h>
+#include <linux/sizes.h>
 #include <trace/events/sock.h>

 #include "nvmet.h"

 #define NVMET_TCP_DEF_INLINE_DATA_SIZE	(4 * PAGE_SIZE)
-#define NVMET_TCP_MAXH2CDATA		0x400000 /* 16M arbitrary limit */
+#define NVMET_TCP_MAXH2CDATA		SZ_4M
 #define NVMET_TCP_BACKLOG 128

 static int param_store_val(const char *str, int *val, int min, int max)
--
2.53.0

Re: [PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA

[Maurizio Lombardi]

On Wed Sep 23, 2026 at 6:20 AM CEST, Ing. Alfonso Kuen Arroyo wrote:
> The constant is 0x400000, 4 MiB, but the comment next to it said 16M.
> Use SZ_4M instead of a value and a comment that can drift out of sync
> with each other, as suggested by Christoph Hellwig.
>
> Noticed by Maurizio Lombardi while reviewing "nvmet-tcp: report a
> bounded MDTS instead of "no limit"".
>
> v2: use SZ_4M instead of the raw hex value + comment (Christoph
>     Hellwig). The file did not pull in linux/sizes.h yet and had no
>     other SZ_ user, so the include is added.

version differences should be put after the '---' separator, they are
not part of the commit message

>
> Signed-off-by: Alfonso Kuen

The mail is missing, this should be:
Signed-off-by: Alfonso Kuen <gerencia@idkmanager.com>

> ---
>  drivers/nvme/target/tcp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
> index e598101..000000 100644
> --- a/drivers/nvme/target/tcp.c
> +++ b/drivers/nvme/target/tcp.c
> @@ -18,12 +18,13 @@
>  #include <net/handshake.h>
>  #include <linux/inet.h>
>  #include <linux/llist.h>
> +#include <linux/sizes.h>
>  #include <trace/events/sock.h>
>
>  #include "nvmet.h"
>
>  #define NVMET_TCP_DEF_INLINE_DATA_SIZE	(4 * PAGE_SIZE)
> -#define NVMET_TCP_MAXH2CDATA		0x400000 /* 16M arbitrary limit */
> +#define NVMET_TCP_MAXH2CDATA		SZ_4M
>  #define NVMET_TCP_BACKLOG 128
>
>  static int param_store_val(const char *str, int *val, int min, int max)
> --
> 2.53.0

The change looks ok to me
Reviewed-by: Maurizio Lombardi <mlombard@redhat.com>

Re: [PATCH v2] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA

[Christoph Hellwig]

On Wed, Sep 23, 2026 at 09:39:59AM +0200, Maurizio Lombardi wrote:
> On Wed Sep 23, 2026 at 6:20 AM CEST, Ing. Alfonso Kuen Arroyo wrote:
> > The constant is 0x400000, 4 MiB, but the comment next to it said 16M.
> > Use SZ_4M instead of a value and a comment that can drift out of sync
> > with each other, as suggested by Christoph Hellwig.
> >
> > Noticed by Maurizio Lombardi while reviewing "nvmet-tcp: report a
> > bounded MDTS instead of "no limit"".
> >
> > v2: use SZ_4M instead of the raw hex value + comment (Christoph
> >     Hellwig). The file did not pull in linux/sizes.h yet and had no
> >     other SZ_ user, so the include is added.
> 
> version differences should be put after the '---' separator, they are
> not part of the commit message
> 
> >
> > Signed-off-by: Alfonso Kuen
> 
> The mail is missing, this should be:
> Signed-off-by: Alfonso Kuen <gerencia@idkmanager.com>

Agreed on both.  Otherwise this looks great, thanks.