From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: vulab@iscas.ac.cn, davem@davemloft.net, david+nfc@ixit.cz,
edumazet@google.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
oe-linux-nfc@lists.linux.dev, pabeni@redhat.com,
sameo@linux.intel.com, stable@vger.kernel.org
Subject: Re: [PATCH] nfc: llcp: Fix socket reference leak in nfc_llcp_recv_ui()
Date: Fri, 25 Sep 2026 10:04:23 +0100 [thread overview]
Message-ID: <20260925090423.GG13925@horms.kernel.org> (raw)
In-Reply-To: <178989049996.2160803.13194045712273112388@kernel.org>
On Sun, Sep 20, 2026 at 07:48:19AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 (1) · High: 1 · Medium: 0 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] Incomplete fix: the identical nfc_llcp_sock_get() reference leak
> remains at the sibling call site in nfc_llcp_recv_connect()…
This concern matches my analysis.
I would suggest an updated patch that fixes both functions.
>
> Pre-existing issues:
> - [Critical] Post-handoff SKB access / use-after-free race in
> nfc_llcp_recv_ui() (net/nfc/llcp_core.c:902-907): the extra SKB…
...
next prev parent reply other threads:[~2026-09-25 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 7:34 Wentao Liang
2026-09-16 8:37 ` Xuanqiang Luo
2026-09-20 7:48 ` netdev-bot+sashiko
2026-09-25 9:04 ` Simon Horman [this message]
2026-09-21 15:11 ` krzk
2026-09-21 15:12 ` krzk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925090423.GG13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=david+nfc@ixit.cz \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®