* [PATCH v2] dt-bindings: mfd: hisilicon: Fix Hi6421 SPMI compatible
@ 2026-09-23 19:15 Rob Herring (Arm)
2026-09-24 14:03 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-09-23 19:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Lee Jones, Krzysztof Kozlowski, Conor Dooley
Cc: linux-kernel, mfd, devicetree
Use the hisilicon,hi6421-spmi compatible documented by the in-tree DTS
and matched by the Hi6421 SPMI PMIC driver.
Assisted-by: LLM
Fixes: dee8a4e807dc ("dt-bindings: mfd: Convert hisilicon,hi6421-pmic to DT schema")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
- Drop "gpios" addition.
---
.../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
index 6a824351834e..0dd37c40eeff 100644
--- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
@@ -24,7 +24,7 @@ properties:
pattern: "pmic@[0-9a-f]"
compatible:
- const: hisilicon,hi6421v600-spmi
+ const: hisilicon,hi6421-spmi
reg:
maxItems: 1
@@ -66,7 +66,7 @@ examples:
#size-cells = <0>;
pmic@0 {
- compatible = "hisilicon,hi6421v600-spmi";
+ compatible = "hisilicon,hi6421-spmi";
reg = <0 SPMI_USID>;
#interrupt-cells = <2>;
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: mfd: hisilicon: Fix Hi6421 SPMI compatible
2026-09-23 19:15 [PATCH v2] dt-bindings: mfd: hisilicon: Fix Hi6421 SPMI compatible Rob Herring (Arm)
@ 2026-09-24 14:03 ` Lee Jones
2026-09-25 12:11 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2026-09-24 14:03 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
linux-kernel, mfd, devicetree
On Wed, 23 Sep 2026, Rob Herring (Arm) wrote:
> Use the hisilicon,hi6421-spmi compatible documented by the in-tree DTS
> and matched by the Hi6421 SPMI PMIC driver.
>
> Assisted-by: LLM
> Fixes: dee8a4e807dc ("dt-bindings: mfd: Convert hisilicon,hi6421-pmic to DT schema")
What is this commit? I don't see it anywhere.
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> v2:
> - Drop "gpios" addition.
> ---
> .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> index 6a824351834e..0dd37c40eeff 100644
> --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
> @@ -24,7 +24,7 @@ properties:
> pattern: "pmic@[0-9a-f]"
>
> compatible:
> - const: hisilicon,hi6421v600-spmi
> + const: hisilicon,hi6421-spmi
>
> reg:
> maxItems: 1
> @@ -66,7 +66,7 @@ examples:
> #size-cells = <0>;
>
> pmic@0 {
> - compatible = "hisilicon,hi6421v600-spmi";
> + compatible = "hisilicon,hi6421-spmi";
> reg = <0 SPMI_USID>;
>
> #interrupt-cells = <2>;
> --
> 2.53.0
>
--
Lee Jones
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: mfd: hisilicon: Fix Hi6421 SPMI compatible
2026-09-24 14:03 ` Lee Jones
@ 2026-09-25 12:11 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2026-09-25 12:11 UTC (permalink / raw)
To: Lee Jones
Cc: Mauro Carvalho Chehab, Krzysztof Kozlowski, Conor Dooley,
linux-kernel, mfd, devicetree
On Thu, Sep 24, 2026 at 03:03:00PM +0100, Lee Jones wrote:
> On Wed, 23 Sep 2026, Rob Herring (Arm) wrote:
>
> > Use the hisilicon,hi6421-spmi compatible documented by the in-tree DTS
> > and matched by the Hi6421 SPMI PMIC driver.
> >
> > Assisted-by: LLM
> > Fixes: dee8a4e807dc ("dt-bindings: mfd: Convert hisilicon,hi6421-pmic to DT schema")
>
> What is this commit? I don't see it anywhere.
Uhh, that's the wrong commit. I'd just drop it. This binding started off
in staging. Originally the compatible was wrong, but the example was
right. Then the example was 'fixed'.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-25 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23 19:15 [PATCH v2] dt-bindings: mfd: hisilicon: Fix Hi6421 SPMI compatible Rob Herring (Arm)
2026-09-24 14:03 ` Lee Jones
2026-09-25 12:11 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®