mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mohamed Jouini <amad3v@gmail.com>
To: "Armin Wolf" <W_Armin@gmx.de>, "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mohamed Jouini <amad3v@gmail.com>
Subject: [PATCH 2/3] platform/x86: uniwill-laptop: Add platform profile support
Date: Fri, 25 Sep 2026 22:16:34 +0100	[thread overview]
Message-ID: <20260925211635.1422516-3-amad3v@gmail.com> (raw)
In-Reply-To: <20260925211635.1422516-1-amad3v@gmail.com>

The EC exposes the three firmware power modes (BIOS "office", "balance"
and "turbo") in EC_ADDR_MANUAL_FAN_CTRL. The ACPI tables name BIT(4) TBME
and BIT(7) UFME and only evaluate those two bits; writing the register
makes the EC apply the whole mode: mode LED colour, NVIDIA Dynamic
Boost/TPP limits (DBAP/ETPP) and the _Q88 mode-change notification.

Expose the modes as low-power/balanced/performance platform profiles on
the PCSpecialist Recoil 16 AMD and handle the mode key: the EC only
cycles the mode itself until the OS sets one, afterwards it just reports
UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE, so notify userspace if the EC
already switched and cycle the profile otherwise.

Signed-off-by: Mohamed Jouini <amad3v@gmail.com>
---
 drivers/platform/x86/uniwill/uniwill-acpi.c | 133 +++++++++++++++++++-
 1 file changed, 132 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index beba5a76a..0932e5937 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -39,6 +39,7 @@
 #include <linux/mutex.h>
 #include <linux/notifier.h>
 #include <linux/platform_device.h>
+#include <linux/platform_profile.h>
 #include <linux/pm.h>
 #include <linux/printk.h>
 #include <linux/regmap.h>
@@ -184,6 +185,15 @@
 #define FAN_MODE_HIGH			BIT(5)
 #define FAN_MODE_BOOST			BIT(6)
 #define FAN_MODE_USER			BIT(7)
+/*
+ * Firmware power modes (BIOS "office/balance/turbo"). The ACPI tables name
+ * BIT(4) TBME and BIT(7) UFME and only evaluate those two bits; the values
+ * below are exactly what the EC itself stores when the mode button is pressed.
+ */
+#define PERF_MODE_MASK			(FAN_MODE_USER | FAN_MODE_HIGH | FAN_MODE_TURBO)
+#define PERF_MODE_OFFICE		(FAN_MODE_USER | FAN_MODE_HIGH)
+#define PERF_MODE_BALANCE		FAN_MODE_HIGH
+#define PERF_MODE_TURBO			(FAN_MODE_HIGH | FAN_MODE_TURBO)
 
 #define EC_ADDR_PWM_1			0x075B
 
@@ -369,6 +379,7 @@
 #define UNIWILL_FEATURE_KEYBOARD_BACKLIGHT	BIT(12)
 #define UNIWILL_FEATURE_AC_AUTO_BOOT		BIT(13)
 #define UNIWILL_FEATURE_USB_POWERSHARE		BIT(14)
+#define UNIWILL_FEATURE_PERFORMANCE_MODES	BIT(15)
 
 enum usb_c_power_priority_options {
 	USB_C_POWER_PRIORITY_CHARGING = 0,
@@ -418,6 +429,8 @@ struct uniwill_data {
 	struct notifier_block nb;
 	struct mutex usb_c_power_priority_lock; /* Protects dependent bit write and state safe */
 	enum usb_c_power_priority_options last_usb_c_power_priority_option;
+	struct device *ppdev;
+	enum platform_profile_option last_profile;	/* last profile read or written */
 };
 
 struct uniwill_battery_entry {
@@ -602,6 +615,7 @@ static bool uniwill_writeable_reg(struct device *dev, unsigned int reg)
 	case EC_ADDR_LIGHTBAR_AC_GREEN:
 	case EC_ADDR_LIGHTBAR_AC_BLUE:
 	case EC_ADDR_BIOS_OEM:
+	case EC_ADDR_MANUAL_FAN_CTRL:
 	case EC_ADDR_TRIGGER:
 	case EC_ADDR_RGB_RED:
 	case EC_ADDR_RGB_GREEN:
@@ -643,6 +657,7 @@ static bool uniwill_readable_reg(struct device *dev, unsigned int reg)
 	case EC_ADDR_LIGHTBAR_AC_GREEN:
 	case EC_ADDR_LIGHTBAR_AC_BLUE:
 	case EC_ADDR_BIOS_OEM:
+	case EC_ADDR_MANUAL_FAN_CTRL:
 	case EC_ADDR_PWM_1:
 	case EC_ADDR_PWM_2:
 	case EC_ADDR_SUPPORT_2:
@@ -682,6 +697,7 @@ static bool uniwill_volatile_reg(struct device *dev, unsigned int reg)
 	case EC_ADDR_SECOND_FAN_RPM_2:
 	case EC_ADDR_BAT_ALERT:
 	case EC_ADDR_BIOS_OEM:
+	case EC_ADDR_MANUAL_FAN_CTRL:
 	case EC_ADDR_PWM_1:
 	case EC_ADDR_PWM_2:
 	case EC_ADDR_SUPPORT_2:
@@ -2168,6 +2184,110 @@ static int uniwill_battery_init(struct uniwill_data *data)
 	return devm_battery_hook_register(data->dev, &data->hook);
 }
 
+static int uniwill_platform_profile_probe(void *drvdata, unsigned long *choices)
+{
+	set_bit(PLATFORM_PROFILE_LOW_POWER, choices);
+	set_bit(PLATFORM_PROFILE_BALANCED, choices);
+	set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
+
+	return 0;
+}
+
+static int uniwill_platform_profile_get(struct device *dev, enum platform_profile_option *profile)
+{
+	struct uniwill_data *data = dev_get_drvdata(dev);
+	unsigned int value;
+	int ret;
+
+	ret = regmap_read(data->regmap, EC_ADDR_MANUAL_FAN_CTRL, &value);
+	if (ret < 0)
+		return ret;
+
+	/* Same decision as the firmware's PMSC method */
+	switch (value & (FAN_MODE_USER | FAN_MODE_TURBO)) {
+	case FAN_MODE_USER:
+		*profile = PLATFORM_PROFILE_LOW_POWER;
+		break;
+	case FAN_MODE_TURBO:
+		*profile = PLATFORM_PROFILE_PERFORMANCE;
+		break;
+	default:
+		*profile = PLATFORM_PROFILE_BALANCED;
+		break;
+	}
+
+	WRITE_ONCE(data->last_profile, *profile);
+
+	return 0;
+}
+
+static int uniwill_platform_profile_set(struct device *dev, enum platform_profile_option profile)
+{
+	struct uniwill_data *data = dev_get_drvdata(dev);
+	unsigned int value;
+	int ret;
+
+	switch (profile) {
+	case PLATFORM_PROFILE_LOW_POWER:
+		value = PERF_MODE_OFFICE;
+		break;
+	case PLATFORM_PROFILE_BALANCED:
+		value = PERF_MODE_BALANCE;
+		break;
+	case PLATFORM_PROFILE_PERFORMANCE:
+		value = PERF_MODE_TURBO;
+		break;
+	default:
+		return -EOPNOTSUPP;
+	}
+
+	/* The EC applies the mode (LED, power limits, ACPI notifications) itself */
+	ret = regmap_update_bits(data->regmap, EC_ADDR_MANUAL_FAN_CTRL, PERF_MODE_MASK, value);
+	if (ret < 0)
+		return ret;
+
+	WRITE_ONCE(data->last_profile, profile);
+
+	return 0;
+}
+
+static const struct platform_profile_ops uniwill_platform_profile_ops = {
+	.probe = uniwill_platform_profile_probe,
+	.profile_get = uniwill_platform_profile_get,
+	.profile_set = uniwill_platform_profile_set,
+};
+
+static int uniwill_platform_profile_init(struct uniwill_data *data)
+{
+	if (!uniwill_device_supports(data, UNIWILL_FEATURE_PERFORMANCE_MODES))
+		return 0;
+
+	data->ppdev = devm_platform_profile_register(data->dev, DRIVER_NAME, data,
+						     &uniwill_platform_profile_ops);
+	if (IS_ERR(data->ppdev))
+		return PTR_ERR(data->ppdev);
+
+	return uniwill_platform_profile_get(data->ppdev, &data->last_profile);
+}
+
+/*
+ * The EC only cycles the mode on its own until the OS sets a mode once; after
+ * that the button just reports UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE. Handle
+ * both cases: if the EC already switched, only notify userspace, otherwise
+ * cycle the profile ourselves.
+ */
+static void uniwill_platform_profile_button(struct uniwill_data *data)
+{
+	enum platform_profile_option before = READ_ONCE(data->last_profile), now;
+
+	msleep(100);	/* give the EC time to apply its own switch, if any */
+
+	if (!uniwill_platform_profile_get(data->ppdev, &now) && now != before)
+		platform_profile_notify(data->ppdev);
+	else
+		platform_profile_cycle();
+}
+
 static int uniwill_notifier_call(struct notifier_block *nb, unsigned long action, void *dummy)
 {
 	struct uniwill_data *data = container_of(nb, struct uniwill_data, nb);
@@ -2239,6 +2359,12 @@ static int uniwill_notifier_call(struct notifier_block *nb, unsigned long action
 			return NOTIFY_DONE;
 
 		return notifier_from_errno(uniwill_notify_kbd_led(data, 4));
+	case UNIWILL_OSD_PERFORMANCE_MODE_TOGGLE:
+		if (uniwill_device_supports(data, UNIWILL_FEATURE_PERFORMANCE_MODES)) {
+			uniwill_platform_profile_button(data);
+			return NOTIFY_OK;
+		}
+		fallthrough;
 	default:
 		mutex_lock(&data->input_lock);
 		sparse_keymap_report_event(data->input_device, action, 1, true);
@@ -2375,6 +2501,10 @@ static int uniwill_probe(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
+	ret = uniwill_platform_profile_init(data);
+	if (ret < 0)
+		return ret;
+
 	return uniwill_input_init(data);
 }
 
@@ -2797,7 +2927,8 @@ static struct uniwill_device_descriptor pcs_recoil16_amd_descriptor __initdata =
 		    UNIWILL_FEATURE_SECONDARY_FAN |
 		    UNIWILL_FEATURE_NVIDIA_CTGP_CONTROL |
 		    UNIWILL_FEATURE_AC_AUTO_BOOT |
-		    UNIWILL_FEATURE_USB_POWERSHARE,
+		    UNIWILL_FEATURE_USB_POWERSHARE |
+		    UNIWILL_FEATURE_PERFORMANCE_MODES,
 };
 
 static int phxtxx1_probe(struct uniwill_data *data)
-- 
2.55.0


  parent reply	other threads:[~2026-09-25 21:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 21:16 [PATCH 0/3] platform/x86: uniwill-laptop: Support the PCSpecialist Recoil 16 AMD Mohamed Jouini
2026-09-25 21:16 ` [PATCH 1/3] platform/x86: uniwill-laptop: Add " Mohamed Jouini
2026-09-25 23:44   ` Armin Wolf
2026-09-26  0:24     ` Am Dev
2026-09-25 21:16 ` Mohamed Jouini [this message]
2026-09-25 23:54   ` [PATCH 2/3] platform/x86: uniwill-laptop: Add platform profile support Armin Wolf
2026-09-26  0:33     ` Am Dev
2026-09-25 21:16 ` [PATCH 3/3] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
2026-09-25 23:52   ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925211635.1422516-3-amad3v@gmail.com \
    --to=amad3v@gmail.com \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®