mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Am Dev <amad3v@gmail.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] platform/x86: uniwill-laptop: Add PCSpecialist Recoil 16 AMD
Date: Sat, 26 Sep 2026 01:24:28 +0100	[thread overview]
Message-ID: <CADfX_O2Q9NEfRcev78jb-BL_vuHZ0eC-W829hkAV65fRto_dwQ@mail.gmail.com> (raw)
In-Reply-To: <00235605-05f0-48e7-8561-486b8ddc9c12@gmx.de>

On Sat, 26 Sept 2026 at 00:44, Armin Wolf <W_Armin@gmx.de> wrote:
>
> it is to be expected that the EC firmware will emulate a full charge to 100 percent even
> when battery health conservation is enabled. I strongly warn you against enabling the
> charge limit on machines other that Intel NUC-based models because apparently Uniwill
> considers the charge limit feature as a preview on all other models, so accessing it
> might permanently damage you battery!
>
> I suggest you continue to use the battery charge modes.
>
Hi Armin,

thanks for the warning, I did not know that the charge limit is only a
preview feature on these models. I have stopped using it and will switch
to the battery charge modes in v2.

One question: the EC originally had 0 in EC_ADDR_CHARGE_CTRL, and it is
now 100 after I lifted the limit through charge_control_end_threshold.
Is 100 safe to leave, or should it be restored to 0?

Thanks,
Mohamed

  reply	other threads:[~2026-09-26  0:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 21:16 [PATCH 0/3] platform/x86: uniwill-laptop: Support the " Mohamed Jouini
2026-09-25 21:16 ` [PATCH 1/3] platform/x86: uniwill-laptop: Add " Mohamed Jouini
2026-09-25 23:44   ` Armin Wolf
2026-09-26  0:24     ` Am Dev [this message]
2026-09-25 21:16 ` [PATCH 2/3] platform/x86: uniwill-laptop: Add platform profile support Mohamed Jouini
2026-09-25 23:54   ` Armin Wolf
2026-09-26  0:33     ` Am Dev
2026-09-25 21:16 ` [PATCH 3/3] platform/x86: uniwill-laptop: Map the screen rotation key Mohamed Jouini
2026-09-25 23:52   ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADfX_O2Q9NEfRcev78jb-BL_vuHZ0eC-W829hkAV65fRto_dwQ@mail.gmail.com \
    --to=amad3v@gmail.com \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®