* [PATCH] pmdomain: mediatek: scpsys: add MT7629 support
@ 2026-09-26 9:59 Chuanhong Guo
2026-11-10 10:54 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Chuanhong Guo @ 2026-09-26 9:59 UTC (permalink / raw)
To: Ulf Hansson, Ryder Lee
Cc: Matthias Brugger, AngeloGioacchino Del Regno, linux-pm,
linux-mediatek, linux-arm-kernel, linux-kernel, Chuanhong Guo
MT7629 currently uses the MT7622 domain table through the device tree
fallback compatible. Attempting to power on the WB domain triggers a
warning during boot, and powering off AUDSYS times out.
Add an MT7629-specific match entry to register only ETHSYS, HIF0 and
HIF1, matching the domains exposed by the vendor driver. These occupy
the first three entries in the MT7622 domain table.
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
drivers/pmdomain/mediatek/mtk-scpsys.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c
index efc8f276ffce..2b5bd8d61cb5 100644
--- a/drivers/pmdomain/mediatek/mtk-scpsys.c
+++ b/drivers/pmdomain/mediatek/mtk-scpsys.c
@@ -1073,6 +1073,17 @@ static const struct scp_soc_data mt7623a_data = {
.bus_prot_reg_update = true,
};
+static const struct scp_soc_data mt7629_data = {
+ /* Reuse the MT7622 entries from ETHSYS through HIF1. */
+ .domains = scp_domain_data_mt7622,
+ .num_domains = MT7622_POWER_DOMAIN_HIF1 + 1,
+ .regs = {
+ .pwr_sta_offs = SPM_PWR_STATUS,
+ .pwr_sta2nd_offs = SPM_PWR_STATUS_2ND,
+ },
+ .bus_prot_reg_update = true,
+};
+
static const struct scp_soc_data mt8173_data = {
.domains = scp_domain_data_mt8173,
.num_domains = ARRAY_SIZE(scp_domain_data_mt8173),
@@ -1105,6 +1116,9 @@ static const struct of_device_id of_scpsys_match_tbl[] = {
}, {
.compatible = "mediatek,mt7623a-scpsys",
.data = &mt7623a_data,
+ }, {
+ .compatible = "mediatek,mt7629-scpsys",
+ .data = &mt7629_data,
}, {
.compatible = "mediatek,mt8173-scpsys",
.data = &mt8173_data,
---
base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
change-id: 20260926-b4-mt7629-scpsys-88d0cf37c6e2
Best regards,
--
Chuanhong Guo <gch981213@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] pmdomain: mediatek: scpsys: add MT7629 support
2026-09-26 9:59 [PATCH] pmdomain: mediatek: scpsys: add MT7629 support Chuanhong Guo
@ 2026-11-10 10:54 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2026-11-10 10:54 UTC (permalink / raw)
To: Chuanhong Guo
Cc: Ulf Hansson, Ryder Lee, Matthias Brugger,
AngeloGioacchino Del Regno, linux-pm, linux-mediatek,
linux-arm-kernel, linux-kernel
On Sat, Sep 26, 2026 at 11:59 AM Chuanhong Guo <gch981213@gmail.com> wrote:
>
> MT7629 currently uses the MT7622 domain table through the device tree
> fallback compatible. Attempting to power on the WB domain triggers a
> warning during boot, and powering off AUDSYS times out.
>
> Add an MT7629-specific match entry to register only ETHSYS, HIF0 and
> HIF1, matching the domains exposed by the vendor driver. These occupy
> the first three entries in the MT7622 domain table.
>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/mediatek/mtk-scpsys.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c
> index efc8f276ffce..2b5bd8d61cb5 100644
> --- a/drivers/pmdomain/mediatek/mtk-scpsys.c
> +++ b/drivers/pmdomain/mediatek/mtk-scpsys.c
> @@ -1073,6 +1073,17 @@ static const struct scp_soc_data mt7623a_data = {
> .bus_prot_reg_update = true,
> };
>
> +static const struct scp_soc_data mt7629_data = {
> + /* Reuse the MT7622 entries from ETHSYS through HIF1. */
> + .domains = scp_domain_data_mt7622,
> + .num_domains = MT7622_POWER_DOMAIN_HIF1 + 1,
> + .regs = {
> + .pwr_sta_offs = SPM_PWR_STATUS,
> + .pwr_sta2nd_offs = SPM_PWR_STATUS_2ND,
> + },
> + .bus_prot_reg_update = true,
> +};
> +
> static const struct scp_soc_data mt8173_data = {
> .domains = scp_domain_data_mt8173,
> .num_domains = ARRAY_SIZE(scp_domain_data_mt8173),
> @@ -1105,6 +1116,9 @@ static const struct of_device_id of_scpsys_match_tbl[] = {
> }, {
> .compatible = "mediatek,mt7623a-scpsys",
> .data = &mt7623a_data,
> + }, {
> + .compatible = "mediatek,mt7629-scpsys",
> + .data = &mt7629_data,
> }, {
> .compatible = "mediatek,mt8173-scpsys",
> .data = &mt8173_data,
>
> ---
> base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
> change-id: 20260926-b4-mt7629-scpsys-88d0cf37c6e2
>
> Best regards,
> --
> Chuanhong Guo <gch981213@gmail.com>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-10 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-26 9:59 [PATCH] pmdomain: mediatek: scpsys: add MT7629 support Chuanhong Guo
2026-11-10 10:54 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®