From: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Leonardo Martins Martins <dev.lmmrtns@gmail.com>
Subject: [PATCH 2/4] staging: rtl8723bs: rename local vars in phy_tx_power_limit_to_index()
Date: Sat, 26 Sep 2026 22:12:25 -0300 [thread overview]
Message-ID: <20260926-rtl8723bs-tx-pwr-limit-v1-2-989dcbc113fd@gmail.com> (raw)
In-Reply-To: <20260926-rtl8723bs-tx-pwr-limit-v1-0-989dcbc113fd@gmail.com>
In phy_tx_power_limit_to_index(), there are many mixed-case names and
needlessly verbose names (such as the iterators, in other realtek
drivers they are shortened like in this patch, by renaming them,
accessing the TxPwrLimit_2_4G table takes less space), rename them.
Signed-off-by: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
---
Renamed Variables:
pHalData -> hal_data
Adapter -> adapter
BW40PwrBasedBm2_4G -> pwr_base
regulation -> reg
channel -> ch
rateSection -> rs
tempValue -> tmp
tempPwrLmt -> tmp_pwr_lmt
rfPath -> path
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 48 +++++++++++++-------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 1228be0cbc839041384f3e434d22b4f039d69986..6d8e3b26da6d29863bd0f4f43fba6abcdbdf5c9c 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -739,35 +739,35 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
return pwr_lmt;
}
-void phy_tx_power_limit_to_index(struct adapter *Adapter)
+void phy_tx_power_limit_to_index(struct adapter *adapter)
{
- struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
- struct registry_priv *r = &Adapter->registrypriv;
- u8 BW40PwrBasedBm2_4G = 0x2E;
- u8 regulation, bw, channel, rateSection;
- s8 tempValue = 0, tempPwrLmt = 0;
- u8 rfPath = 0;
+ struct hal_com_data *hal_data = GET_HAL_DATA(adapter);
+ struct registry_priv *r = &adapter->registrypriv;
+ u8 pwr_base = 0x2E;
+ u8 reg, bw, ch, rs;
+ s8 tmp = 0, tmp_pwr_lmt = 0;
+ u8 path = 0;
- for (regulation = 0; regulation < MAX_REGULATION_NUM; ++regulation) {
+ for (reg = 0; reg < MAX_REGULATION_NUM; ++reg) {
for (bw = 0; bw < MAX_2_4G_BANDWIDTH_NUM; ++bw) {
- for (channel = 0; channel < CHANNEL_MAX_NUMBER_2G; ++channel) {
- for (rateSection = 0; rateSection < MAX_RATE_SECTION_NUM; ++rateSection) {
- tempPwrLmt = pHalData->TxPwrLimit_2_4G[regulation][bw][rateSection][channel][RF_PATH_A];
-
- for (rfPath = RF_PATH_A; rfPath < MAX_RF_PATH_NUM; ++rfPath) {
- if (pHalData->odmpriv.PhyRegPgValueType == PHY_REG_PG_EXACT_VALUE) {
- if (rateSection == 2) /* HT 1T */
- BW40PwrBasedBm2_4G = PHY_GetTxPowerByRateBase(Adapter, rfPath, HT_MCS0_MCS7);
- else if (rateSection == 1) /* OFDM */
- BW40PwrBasedBm2_4G = PHY_GetTxPowerByRateBase(Adapter, rfPath, OFDM);
- else if (rateSection == 0) /* CCK */
- BW40PwrBasedBm2_4G = PHY_GetTxPowerByRateBase(Adapter, rfPath, CCK);
+ for (ch = 0; ch < CHANNEL_MAX_NUMBER_2G; ++ch) {
+ for (rs = 0; rs < MAX_RATE_SECTION_NUM; ++rs) {
+ tmp_pwr_lmt = hal_data->TxPwrLimit_2_4G[reg][bw][rs][ch][RF_PATH_A];
+
+ for (path = RF_PATH_A; path < MAX_RF_PATH_NUM; ++path) {
+ if (hal_data->odmpriv.PhyRegPgValueType == PHY_REG_PG_EXACT_VALUE) {
+ if (rs == 2) /* HT 1T */
+ pwr_base = PHY_GetTxPowerByRateBase(adapter, path, HT_MCS0_MCS7);
+ else if (rs == 1) /* OFDM */
+ pwr_base = PHY_GetTxPowerByRateBase(adapter, path, OFDM);
+ else if (rs == 0) /* CCK */
+ pwr_base = PHY_GetTxPowerByRateBase(adapter, path, CCK);
} else
- BW40PwrBasedBm2_4G = r->reg_power_base * 2;
+ pwr_base = r->reg_power_base * 2;
- if (tempPwrLmt != MAX_POWER_INDEX) {
- tempValue = tempPwrLmt - BW40PwrBasedBm2_4G;
- pHalData->TxPwrLimit_2_4G[regulation][bw][rateSection][channel][rfPath] = tempValue;
+ if (tmp_pwr_lmt != MAX_POWER_INDEX) {
+ tmp = tmp_pwr_lmt - pwr_base;
+ hal_data->TxPwrLimit_2_4G[reg][bw][rs][ch][path] = tmp;
}
}
}
--
2.47.3
next prev parent reply other threads:[~2026-09-27 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 1:12 [PATCH 0/4] staging: rtl8723bs: refactor PHY_ConvertTxPowerLimitToPowerIndex() Leonardo Martins Martins
2026-09-27 1:12 ` [PATCH 1/4] staging: rtl8723bs: rename PHY_ConvertTxPowerLimitToPowerIndex() Leonardo Martins Martins
2026-09-27 1:12 ` Leonardo Martins Martins [this message]
2026-10-01 9:31 ` [PATCH 2/4] staging: rtl8723bs: rename local vars in phy_tx_power_limit_to_index() Greg Kroah-Hartman
2026-09-27 1:12 ` [PATCH 3/4] staging: rtl8723bs: access TxPowerByRateBase2_4G directly Leonardo Martins Martins
2026-09-27 1:12 ` [PATCH 4/4] staging: rtl8723bs: extract inner loop in phy_tx_power_limit_to_index() Leonardo Martins Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926-rtl8723bs-tx-pwr-limit-v1-2-989dcbc113fd@gmail.com \
--to=dev.lmmrtns@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®