From: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Leonardo Martins Martins <dev.lmmrtns@gmail.com>
Subject: [PATCH 0/4] staging: rtl8723bs: refactor PHY_ConvertTxPowerLimitToPowerIndex()
Date: Sat, 26 Sep 2026 22:12:23 -0300 [thread overview]
Message-ID: <20260926-rtl8723bs-tx-pwr-limit-v1-0-989dcbc113fd@gmail.com> (raw)
The function PHY_ConvertTxPowerLimitToPowerIndex() has several style
problems, such as mixed-case names, deeply nested code, and redundant
bounds checking.
Patches 1 and 2 rename mixed-case names that are on the same scope as
this function, struct fields such as TxPwrLimit_2_4G were left as is.
Patch 3 removes redundant parts of the code, and patch 4 solves the
nesting issue by extracting the inner loop into an auxiliary function
like it is done in rtw_phy_tx_power_limit_config(), at
drivers/net/wireless/realtek/rtw88/phy.c
Checkpatch issues a few warnings and checks for deep nesting and long
lines, but these are solved by the last patch.
Compile tested only.
Signed-off-by: Leonardo Martins Martins <dev.lmmrtns@gmail.com>
---
Leonardo Martins Martins (4):
staging: rtl8723bs: rename PHY_ConvertTxPowerLimitToPowerIndex()
staging: rtl8723bs: rename local vars in phy_tx_power_limit_to_index()
staging: rtl8723bs: access TxPowerByRateBase2_4G directly
staging: rtl8723bs: extract inner loop in phy_tx_power_limit_to_index()
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 88 ++++++++--------------
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
drivers/staging/rtl8723bs/include/hal_com_phycfg.h | 5 +-
3 files changed, 32 insertions(+), 63 deletions(-)
---
base-commit: 8444548bd905f22093729065408284a6b46f7eee
change-id: 20260922-rtl8723bs-tx-pwr-limit-9a19bb9f901e
Best regards,
--
Leonardo Martins Martins <dev.lmmrtns@gmail.com>
next reply other threads:[~2026-09-27 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 1:12 Leonardo Martins Martins [this message]
2026-09-27 1:12 ` [PATCH 1/4] staging: rtl8723bs: rename PHY_ConvertTxPowerLimitToPowerIndex() Leonardo Martins Martins
2026-09-27 1:12 ` [PATCH 2/4] staging: rtl8723bs: rename local vars in phy_tx_power_limit_to_index() Leonardo Martins Martins
2026-10-01 9:31 ` Greg Kroah-Hartman
2026-09-27 1:12 ` [PATCH 3/4] staging: rtl8723bs: access TxPowerByRateBase2_4G directly Leonardo Martins Martins
2026-09-27 1:12 ` [PATCH 4/4] staging: rtl8723bs: extract inner loop in phy_tx_power_limit_to_index() Leonardo Martins Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926-rtl8723bs-tx-pwr-limit-v1-0-989dcbc113fd@gmail.com \
--to=dev.lmmrtns@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®