From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Donggeun Yoo <donggeunyoo.kernel@gmail.com>,
akpm@linux-foundation.org, rppt@kernel.org, peterx@redhat.com,
surenb@google.com, aarcange@redhat.com, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, mhocko@suse.com,
shuah@kernel.org, kirill@shutemov.name, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] selftests/mm: add a test for UFFDIO_MOVE of a write-protected swap entry
Date: Sat, 26 Sep 2026 16:21:26 +0900 [thread overview]
Message-ID: <20260926072126.2870142-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <226ec797-ff8c-4465-a682-21c684a25021@kernel.org>
On Fri, 25 Sep 2026 09:41:24 +0200, David Hildenbrand (Arm) wrote:
> Is this loop really required? I thought the page should just be unmapped from
> the page table. It might still be in the swapcache and under writeback, but
> that's irrelevant.
No, one call was enough in every run I did. v3 calls it once and skips if
the page isn't swapped out.
> Do we also want to check wrp? I'd assume it suffers from the same problem (did
> not check carefully though)
Yes, it does. v3 adds a move-swap-rwp case, which fails without patch 1
and passes with it.
Thanks,
Donggeun
prev parent reply other threads:[~2026-09-26 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 4:29 [PATCH v2 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Donggeun Yoo
2026-09-25 4:29 ` [PATCH v2 1/2] " Donggeun Yoo
2026-09-25 4:48 ` Andrew Morton
2026-09-25 7:36 ` David Hildenbrand (Arm)
2026-09-26 7:11 ` Donggeun Yoo
2026-09-25 4:29 ` [PATCH v2 2/2] selftests/mm: add a test for UFFDIO_MOVE of a write-protected swap entry Donggeun Yoo
2026-09-25 7:41 ` David Hildenbrand (Arm)
2026-09-26 7:21 ` Donggeun Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926072126.2870142-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=kirill@shutemov.name \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®