[PATCH] selftests/nci: skip when the virtual NCI device is absent

[PATCH] selftests/nci: skip when the virtual NCI device is absent

[Eva Kurchatova]

All 8 tests fail in setup without CONFIG_NFC_VIRTUAL_NCI.

Skip only when the device node is missing, so that a real open()
failure, EPERM or EBUSY, still fails the test instead of being
reported as a skip.

Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
---
 tools/testing/selftests/nci/nci_dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index 07427fa42888..cb567d6f32ed 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -430,6 +430,8 @@ FIXTURE_SETUP(NCI)
 	ASSERT_NE(self->fid, -1);
 
 	self->virtual_nci_fd = open("/dev/virtual_nci", O_RDWR);
+	if (self->virtual_nci_fd < 0 && errno == ENOENT)
+		SKIP(return, "virtual NCI device is not available");
 	ASSERT_GT(self->virtual_nci_fd, -1);
 
 	rc = setsockopt(self->sd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &event_group,
-- 
2.55.0

Re: [PATCH] selftests/nci: skip when the virtual NCI device is absent

[Simon Horman]

On Fri, Sep 25, 2026 at 04:41:59PM +0300, Eva Kurchatova wrote:
> All 8 tests fail in setup without CONFIG_NFC_VIRTUAL_NCI.
> 
> Skip only when the device node is missing, so that a real open()
> failure, EPERM or EBUSY, still fails the test instead of being
> reported as a skip.
> 
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

Hi Eva,

I expect that tests are expected to run with tools/testing/selftests/nci/config
Which has CONFIG_NFC_VIRTUAL_NCI set.

So, as per Jakub's comment's elsewhere [1], this seems like another case where
either the environment should be updated or a local patch carried.

[1] Re: [PATCH] selftests: netdevsim: skip the rate tc-bw check without tool support
    https://lore.kernel.org/netdev/20260925171154.79c372fc@kernel.org/

-- 
pw-bot: reject