[PATCH 0/3] sched: Minor comment fixes and cleanups

[PATCH 0/3] sched: Minor comment fixes and cleanups

[Kayra Cizmeci]

Hi all,

This patch series is about cleanups and minor comment fixes
that I stumbled in sched. I sent some of them earlier, alone.

But I thought getting them on a series would be better. Old ones
already didn't got any responses.

1/3 came out while reviewing Wei's patch, here:
  https://lore.kernel.org/lkml/20260920111535.117996-1-kayracizmeci@gmail.com/

2/3 was posted earlier here:
  https://lore.kernel.org/lkml/20260822135432.327466-1-kayracizmeci@gmail.com/

3/3, it's too old:
  https://lore.kernel.org/lkml/20260726160238.107142-1-kayracizmeci@gmail.com/

Also, there could be minor changes on the patches that was posted
earlier.

NOTE: Because Wei's patch is still developing, if it enters the code
text below the comment needs to be changed as well. (The comment in 1/3)

Kayra Cizmeci (3):
  sched/stats: Fix comment in sched_info_enqueue()
  sched/fair: Fix typo in requeue_delayed_entity() comment
  sched/fair: Remove unused autogroup.h include

 kernel/sched/fair.c  | 3 +--
 kernel/sched/stats.h | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.53.0

[PATCH 1/3] sched/stats: Fix comment in sched_info_enqueue()

[Kayra Cizmeci]

The comment currently states that sched_info_enqueue() is
only called from enqueue_task(). This is wrong since
sched_info_enqueue() gets called from sched_info_depart() too.

Fix it by adding the information that sched_info_enqueue()
is called from sched_info_depart() too.

Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
---
 kernel/sched/stats.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
index ebe0a7765f98..aecca78acc1a 100644
--- a/kernel/sched/stats.h
+++ b/kernel/sched/stats.h
@@ -284,8 +284,8 @@ static void sched_info_arrive(struct rq *rq, struct task_struct *t)
 }
 
 /*
- * This function is only called from enqueue_task(), but also only updates
- * the timestamp if it is already not set.  It's assumed that
+ * This function is only called from enqueue_task() and sched_info_depart(),
+ * but only updates the timestamp if it is already not set. It's assumed that
  * sched_info_dequeue() will clear that stamp when appropriate.
  */
 static inline void sched_info_enqueue(struct rq *rq, struct task_struct *t)
-- 
2.53.0

[PATCH 2/3] sched/fair: Fix typo in requeue_delayed_entity() comment

[Kayra Cizmeci]

'elegibility' should be 'eligibility'

Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 7455a83a6a99..ddf993a46e3d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7913,7 +7913,7 @@ requeue_delayed_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
 	/*
 	 * se->sched_delayed should imply: se->on_rq == 1.
 	 * Because a delayed entity is one that is still on
-	 * the runqueue competing until elegibility.
+	 * the runqueue competing until eligibility.
 	 */
 	WARN_ON_ONCE(!se->sched_delayed);
 	WARN_ON_ONCE(!se->on_rq);
-- 
2.53.0

[PATCH 3/3] sched/fair: Remove unused autogroup.h include

[Kayra Cizmeci]

autogroup.h is included to fair.c, but not used, remove it.

Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
---
 kernel/sched/fair.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ddf993a46e3d..051e93b495d5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -59,7 +59,6 @@
 
 #include "sched.h"
 #include "stats.h"
-#include "autogroup.h"
 
 /*
  * The initial- and re-scaling of tunables is configurable
-- 
2.53.0