* [PATCH] dmaengine: fsl_raid: use !desc for NULL check
@ 2026-09-27 20:52 Rosen Penev
2026-09-28 16:45 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-09-27 20:52 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Frank Li, open list
<= 0 is flagged by sparse as being used for integer, not pointer
comparison. Fix the warning.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/fsl_raid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index 9cc289f7129e..8e7026682d0a 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -346,7 +346,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_genq(
}
desc = fsl_re_chan_alloc_desc(re_chan, flags);
- if (desc <= 0)
+ if (!desc)
return NULL;
if (scf && (flags & DMA_PREP_CONTINUE)) {
@@ -470,7 +470,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_pq(
src_cnt += 3;
desc = fsl_re_chan_alloc_desc(re_chan, flags);
- if (desc <= 0)
+ if (!desc)
return NULL;
/* Filling GenQQ CDB */
@@ -554,7 +554,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_memcpy(
}
desc = fsl_re_chan_alloc_desc(re_chan, flags);
- if (desc <= 0)
+ if (!desc)
return NULL;
/* Filling move CDB */
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: fsl_raid: use !desc for NULL check
2026-09-27 20:52 [PATCH] dmaengine: fsl_raid: use !desc for NULL check Rosen Penev
@ 2026-09-28 16:45 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-09-28 16:45 UTC (permalink / raw)
To: Rosen Penev; +Cc: dmaengine, Vinod Koul, Frank Li, open list
On Sun, Sep 27, 2026 at 01:52:24PM -0700, Rosen Penev wrote:
> <= 0 is flagged by sparse as being used for integer, not pointer
> comparison. Fix the warning.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/fsl_raid.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 9cc289f7129e..8e7026682d0a 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
> @@ -346,7 +346,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_genq(
> }
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> if (scf && (flags & DMA_PREP_CONTINUE)) {
> @@ -470,7 +470,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_pq(
> src_cnt += 3;
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> /* Filling GenQQ CDB */
> @@ -554,7 +554,7 @@ static struct dma_async_tx_descriptor *fsl_re_prep_dma_memcpy(
> }
>
> desc = fsl_re_chan_alloc_desc(re_chan, flags);
> - if (desc <= 0)
> + if (!desc)
> return NULL;
>
> /* Filling move CDB */
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-28 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-27 20:52 [PATCH] dmaengine: fsl_raid: use !desc for NULL check Rosen Penev
2026-09-28 16:45 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®