From: Yili Zhang <zhangyili01@baidu.com>
To: <linux-cxl@vger.kernel.org>
Cc: Dan Williams <djbw@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jic23@kernel.org>,
Shiju Jose <shiju.jose@huawei.com>,
<linux-kernel@vger.kernel.org>,
Yili Zhang <zhangyili01@baidu.com>
Subject: [PATCH] cxl/edac: Bounds-check ECS threshold index from device
Date: Mon, 28 Sep 2026 15:35:53 +0800 [thread overview]
Message-ID: <20260928073553.85669-1-zhangyili01@baidu.com> (raw)
cxl_get_ecs_threshold() extracts a 3-bit index (0-7) from the
device-supplied ECS config word and uses it to
index ecs_supp_threshold[], which only has 6 elements. A device reporting
index 6 or 7 causes an out-of-bounds read of adjacent .rodata, whose
value is then returned to userspace via the EDAC 'threshold' sysfs
attribute (small info leak and wrong reported threshold).
Return 0 for indices outside the table.
Fixes: 85fb6a16ad14 ("cxl/edac: Add CXL memory device ECS control feature")
Signed-off-by: Yili Zhang <zhangyili01@baidu.com>
---
drivers/cxl/core/edac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c
index b321971fef58..73335b980b11 100644
--- a/drivers/cxl/core/edac.c
+++ b/drivers/cxl/core/edac.c
@@ -633,6 +633,9 @@ static u16 cxl_get_ecs_threshold(u8 log_cap, u16 config)
{
u8 index = FIELD_GET(CXL_ECS_THRESHOLD_COUNT_MASK, config);
+ if (index >= ARRAY_SIZE(ecs_supp_threshold))
+ return 0;
+
return ecs_supp_threshold[index];
}
--
2.27.0
next reply other threads:[~2026-09-28 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 7:35 Yili Zhang [this message]
2026-09-28 18:21 ` Dave Jiang
2026-09-29 3:17 ` Yili Zhang
2026-09-29 17:53 ` Alison Schofield
2026-09-30 9:09 ` Yili Zhang
2026-09-30 9:56 ` [PATCH v2] cxl/edac: Fail ECS threshold read for reserved encodings Yili Zhang
2026-10-20 21:27 ` Jonathan Cameron
2026-10-21 13:14 ` Yili Zhang
2026-10-21 15:58 ` Alison Schofield
2026-10-29 12:37 ` Yili Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928073553.85669-1-zhangyili01@baidu.com \
--to=zhangyili01@baidu.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®