mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Surendran Kanagaraj <surenkj@amazon.com>
To: <jarkko@kernel.org>
Cc: <graf@amazon.de>, <gunnarku@amazon.com>, <jgg@ziepe.ca>,
	<joshlev@amazon.com>, <linux-integrity@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <nh-open-source@amazon.com>,
	<peterhuewe@gmx.de>, <surenkj@amazon.com>
Subject: Re: [PATCH 2/2] tpm_crb: Raise timeouts for Amazon NitroTPM
Date: Mon, 28 Sep 2026 21:09:53 +0000	[thread overview]
Message-ID: <20260928210953.29183-1-surenkj@amazon.com> (raw)
In-Reply-To: <araZZzKDqzrPdY9f@kernel.org>

On Fri, Sep 25, 2026, Jarkko Sakkinen wrote:
> On Wed, Sep 23, 2026 at 02:28:34PM +0000, Surendran Kanagaraj wrote:
> > +/* Longest unavailability seen from NitroTPM */
> > +#define CRB_AMZN_BUSY_TIMEOUT_MS     30000
>
> Use TPM_CRB prefix.

Thanks for taking time to review my patches. Will update this in v2.

> > +	crb_apply_vendor_quirks(priv, chip);
>
> I.e., all this complexity equals to:
>
>         if (crb_vendor_id(priv) == CRB_INTF_VID_AMZN)
>                 chip->busy_timeout_ms = CRB_AMZN_BUSY_TIMEOUT_MS;
>
> ?

Yes. I added the table to keep vendor specific quirks out of the probe
and could be extended without touching the probe. tpm_tis_core does
something similar with vendor_dur_overrides. what do you think? I am
happy to switch to the plain check if you prefer.

Thanks,
Surendran

  reply	other threads:[~2026-09-28 21:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 14:28 [PATCH 0/2] tpm: Handle transient NitroTPM unavailability Surendran Kanagaraj
2026-09-23 14:28 ` [PATCH 1/2] tpm: Add per-chip timeout for transient unavailability Surendran Kanagaraj
2026-09-25  9:04   ` Breno Leitao
2026-09-28 19:50     ` Surendran Kanagaraj
2026-09-29 22:15       ` Jarkko Sakkinen
2026-09-25 16:03   ` Jarkko Sakkinen
2026-09-29 13:21     ` Surendran Kanagaraj
2026-09-23 14:28 ` [PATCH 2/2] tpm_crb: Raise timeouts for Amazon NitroTPM Surendran Kanagaraj
2026-09-25 15:55   ` Jarkko Sakkinen
2026-09-28 21:09     ` Surendran Kanagaraj [this message]
2026-09-29 22:22       ` Jarkko Sakkinen
2026-09-30 19:15         ` Surendran Kanagaraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928210953.29183-1-surenkj@amazon.com \
    --to=surenkj@amazon.com \
    --cc=graf@amazon.de \
    --cc=gunnarku@amazon.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=joshlev@amazon.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nh-open-source@amazon.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®