mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghuay@nvidia.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <dfustini@baylibre.com>,
	Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
	David E Box <david.e.box@intel.com>,
	x86@kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	Tony Luck <tony.luck@intel.com>
Subject: [PATCH v13 00/25] Allow AET to use PMT as loadable module
Date: Mon, 28 Sep 2026 15:14:44 -0700	[thread overview]
Message-ID: <20260928221509.68002-1-tony.luck@intel.com> (raw)

Requiring INTEL_PMT_TELEMETRY=y to enable AET is a functional workaround
to enable enumeration of Application Energy Telemetry (AET) events, but
unacceptable to many users. It results in increased configuration complexity,
increased kernel memory footprint and inability to patch problems by unloading
a module and loading an updated version.

Add a registration function to the AET code that can be used by
INTEL_PMT_TELEMETRY to provide the enumeration functions.

INTEL_PMT_TELEMETRY can be loaded/unloaded independently of
resctrl file system mount/unmount. Perform enumeration on
every mount and cleanup on every unmount.

Patch series based on TIP tree x86/cache branch current HEAD is:
  a17d099481bd ("x86/resctrl: Update documented unit for the "activity" event")

Signed-off-by: Tony Luck <tony.luck@intel.com>

Previous version (v12) here:
Link: https://lore.kernel.org/all/20260916231320.14502-1-tony.luck@intel.com/

Changes since v12:

[PATCH v13 01/25] fs/resctrl: Ensure default group reports tasks on monitor-only systems
	New patch (split from patch 9)

[PATCH v13 02/25] x86/cpufeatures: Add missing CQM feature dependency
	Added Reinette RB tag

[PATCH v13 03/25] x86/resctrl: Check if monitoring features are supported
	Dropped (Linux: X86_FEATURE_*) from commit comment
	s/specific features/resource specific features/
	s/L3-based monitoring features/L3 monitoring features/
	Added maintainer note about not back porting.

[PATCH v13 04/25] x86/resctrl: Centralize monitoring feature enumeration
	Update commit subject and comment as suggested.

[PATCH v13 05/25] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config()
	Babu:
	s/intel_rdt_mbm_apply_quirk(r->mon.num_rmid)/intel_rdt_mbm_apply_quirk(num_rmid)/

	Reinette:
	Add comment to code describing model specific details of quirk.

[PATCH v13 06/25] x86/resctrl: Delete resctrl_cpu_detect()
	Replaced commit comment with Reinette improved version.

[PATCH v13 07/25] arm,x86,fs/resctrl: Replace architecture resctrl_arch_{alloc,mon}_capable()
	s/is alloc, or mon, capable/is capable of allocation or monitoring/

[PATCH v13 08/25] x86/resctrl: Update special case for Intel Haswell enumeration
	Replaced commit comment with Reinette's improved version.

[PATCH v13 09/25] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable
	Expand commit message.

[PATCH v13 10/25] fs/resctrl: Remove redundant calls to resctrl_mon_capable()
	Moved change to is_closid_match() to its own patch.

[PATCH v13 11/25] x86/resctrl: Honor rdt={perf|energy} options to force enable AET events
	Update subject and commit comment to reflect that this change
	applies equally to rdt=energy.

[PATCH v13 12/25] fs/resctrl: Add interface to disable a monitor event
	Add back the comment that events must not be disabled while
	the file system is mounted.

[PATCH v13 13/25] arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[]
	Updated commit message using Reinette suggestion.
	Merged patch 14 "Rebuild free RMID list on each mount" into
	this patch as the split into separate patches didn't work
	as well as I hoped.

[PATCH v13 14/25] arm,x86,fs/resctrl: Use right size for L3 monitor data structures
	Drop rename of local "idx_limit" to "l3_idx_limit"
	Re-wrote commit message.

[PATCH v13 15/25] x86,fs/resctrl: Handle systems where AET is the only resource
	Add a pr_info() if no L3 features are enabled on a
	"X86_FEATURE_CQM_LLC" system.

	Add a comment for the "return true" from get_rdt_mon_resources()

	Rewrite commit message with context for the change.

[PATCH v13 16/25] x86/resctrl: Add PMT registration API for AET enumeration callbacks
	Rewrote commit message using correct context at this point in the series.
	Use "pmt_telemetry" throughout.

[PATCH v13 17/25] platform/x86/intel/pmt: Register enumeration functions with resctrl
	Dropped empty line in pmt_telem_init()
	Rewrote commit message with accurate context.

[PATCH v13 18/25] x86/resctrl: Use registered function pointers for AET enumeration
	Replace intel_pmt_put_feature_group() call in intel_aet_exit()
	with call via registered function pointer.

	Explain in commit comment that pmt_telemetry is built-in so the
	try_module_get() is a no-op.

[PATCH v13 19/25] arm,x86,fs/resctrl: Enumerate AET on every resctrl mount
	Replace comment about holding resctrl_mount_lock for
	resctrl_arch_pre_mount() and resctrl_arch_unmount()
	with "Serialized against other mount and unmount attempts."

	Dropped stray blank line addition to rdt_get_tree()

	Rewrote commit message. Note that previous iterations of this
	patch series attempted to split into separate parts. But these
	were hard to explain separately.

[PATCH v13 20/25] x86/resctrl: Enforce system RMID limit on AET
	Drop sentence about SNC reducing number of RMIDs as it isn't
	relevant.

	s/lower/higher/ in commit message.

	s/IA32_PQR_ASSOC.RMID/MSR_IA32_PQR_ASSOC.RMID/

	Changed pqr_assoc_num_rmid from static to global.

	Move clamp from arch/x86/kernel/cpu/resctrl/core.c to
	arch/x86/kernel/cpu/resctrl/intel_aet.c

[PATCH v13 21/25] x86/resctrl: Export interface to report telemetry unbind/remove
	Dropped telemetry_region::addr from list of things protected
	by aet_register_lock.

	Declare and use aet_mmio_lock in this patch instead of next one.

	Explain the reason for the new lock.

[PATCH v13 22/25] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed
	Context paragraph added describing the problem.

	New aet_mmio_lock moved to previous patch to avoid
	churn here changing lines that were just changed there.

	Add a comment in code that all entries for a removed device
	are on the same package.

[PATCH v13 23/25] x86/resctrl: Require 64-bit x86 for resctrl support
	Re-order tags
	s/This in line/This is in line/
	s/the state of/reduced/

[PATCH v13 24/25] x86/resctrl: Simplify Kconfig options for resctrl
	Re-order tags.
	Swap "intel_" prefix to "rdt_".

[PATCH v13 25/25] x86,fs/resctrl: Document telemetry mount timing caveat
	Drop the "Mounting resctrl with telemetry" section. Include the
	solution in the footnote.

Tony Luck (25):
  fs/resctrl: Ensure default group reports tasks on monitor-only systems
  x86/cpufeatures: Add missing CQM feature dependency
  x86/resctrl: Check if monitoring features are supported
  x86/resctrl: Centralize monitoring feature enumeration
  x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config()
  x86/resctrl: Delete resctrl_cpu_detect()
  arm,x86,fs/resctrl: Replace architecture
    resctrl_arch_{alloc,mon}_capable()
  x86/resctrl: Update special case for Intel Haswell enumeration
  x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable
  fs/resctrl: Remove redundant calls to resctrl_mon_capable()
  x86/resctrl: Honor rdt={perf|energy} options to force enable AET
    events
  fs/resctrl: Add interface to disable a monitor event
  arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[]
  arm,x86,fs/resctrl: Use right size for L3 monitor data structures
  x86,fs/resctrl: Handle systems where AET is the only resource
  x86/resctrl: Add PMT registration API for AET enumeration callbacks
  platform/x86/intel/pmt: Register enumeration functions with resctrl
  x86/resctrl: Use registered function pointers for AET enumeration
  arm,x86,fs/resctrl: Enumerate AET on every resctrl mount
  x86/resctrl: Enforce system RMID limit on AET
  x86/resctrl: Export interface to report telemetry unbind/remove
  platform/x86/intel/pmt: Inform resctrl when MMIO maps are being
    removed
  x86/resctrl: Require 64-bit x86 for resctrl support
  x86/resctrl: Simplify Kconfig options for resctrl
  x86,fs/resctrl: Document telemetry mount timing caveat

 Documentation/filesystems/resctrl.rst      |   7 +-
 include/linux/arm_mpam.h                   |   3 -
 include/linux/intel_vsec.h                 |  14 ++
 include/linux/resctrl.h                    |  84 +++++++++++-
 arch/x86/include/asm/processor.h           |   4 -
 arch/x86/include/asm/resctrl.h             |  24 +---
 arch/x86/kernel/cpu/resctrl/internal.h     |  31 ++---
 arch/x86/kernel/cpu/amd.c                  |   3 -
 arch/x86/kernel/cpu/cpuid-deps.c           |   1 +
 arch/x86/kernel/cpu/hygon.c                |   3 -
 arch/x86/kernel/cpu/intel.c                |   7 -
 arch/x86/kernel/cpu/resctrl/core.c         | 150 +++++++++++----------
 arch/x86/kernel/cpu/resctrl/intel_aet.c    | 132 ++++++++++++++++--
 arch/x86/kernel/cpu/resctrl/monitor.c      |  78 +++++++----
 drivers/platform/x86/intel/pmt/telemetry.c |  45 ++++++-
 drivers/resctrl/mpam_resctrl.c             |  44 +++---
 fs/resctrl/monitor.c                       | 111 ++++++++++-----
 fs/resctrl/pseudo_lock.c                   |   6 +-
 fs/resctrl/rdtgroup.c                      |  74 ++++++----
 arch/x86/Kconfig                           |  15 +--
 arch/x86/kernel/cpu/resctrl/Makefile       |   3 +-
 21 files changed, 567 insertions(+), 272 deletions(-)


base-commit: a17d099481bd11f0911993a8e69992269f92ad12
-- 
2.55.0


             reply	other threads:[~2026-09-28 22:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 22:14 Tony Luck [this message]
2026-09-28 22:14 ` [PATCH v13 01/25] fs/resctrl: Ensure default group reports tasks on monitor-only systems Tony Luck
2026-09-28 22:14 ` [PATCH v13 02/25] x86/cpufeatures: Add missing CQM feature dependency Tony Luck
2026-09-28 22:14 ` [PATCH v13 03/25] x86/resctrl: Check if monitoring features are supported Tony Luck
2026-09-28 22:14 ` [PATCH v13 04/25] x86/resctrl: Centralize monitoring feature enumeration Tony Luck
2026-09-28 22:14 ` [PATCH v13 05/25] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() Tony Luck
2026-09-28 22:14 ` [PATCH v13 06/25] x86/resctrl: Delete resctrl_cpu_detect() Tony Luck
2026-09-28 22:14 ` [PATCH v13 07/25] arm,x86,fs/resctrl: Replace architecture resctrl_arch_{alloc,mon}_capable() Tony Luck
2026-09-28 22:14 ` [PATCH v13 08/25] x86/resctrl: Update special case for Intel Haswell enumeration Tony Luck
2026-09-28 22:14 ` [PATCH v13 09/25] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable Tony Luck
2026-09-28 22:14 ` [PATCH v13 10/25] fs/resctrl: Remove redundant calls to resctrl_mon_capable() Tony Luck
2026-09-28 22:14 ` [PATCH v13 11/25] x86/resctrl: Honor rdt={perf|energy} options to force enable AET events Tony Luck
2026-09-28 22:14 ` [PATCH v13 12/25] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-09-28 22:14 ` [PATCH v13 13/25] arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[] Tony Luck
2026-09-28 22:14 ` [PATCH v13 14/25] arm,x86,fs/resctrl: Use right size for L3 monitor data structures Tony Luck
2026-09-28 22:14 ` [PATCH v13 15/25] x86,fs/resctrl: Handle systems where AET is the only resource Tony Luck
2026-09-28 22:15 ` [PATCH v13 16/25] x86/resctrl: Add PMT registration API for AET enumeration callbacks Tony Luck
2026-09-28 22:15 ` [PATCH v13 17/25] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-09-28 22:15 ` [PATCH v13 18/25] x86/resctrl: Use registered function pointers for AET enumeration Tony Luck
2026-09-28 22:15 ` [PATCH v13 19/25] arm,x86,fs/resctrl: Enumerate AET on every resctrl mount Tony Luck
2026-09-28 22:15 ` [PATCH v13 20/25] x86/resctrl: Enforce system RMID limit on AET Tony Luck
2026-09-28 22:15 ` [PATCH v13 21/25] x86/resctrl: Export interface to report telemetry unbind/remove Tony Luck
2026-09-28 22:15 ` [PATCH v13 22/25] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed Tony Luck
2026-09-28 22:15 ` [PATCH v13 23/25] x86/resctrl: Require 64-bit x86 for resctrl support Tony Luck
2026-09-28 22:15 ` [PATCH v13 24/25] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-09-28 22:15 ` [PATCH v13 25/25] x86,fs/resctrl: Document telemetry mount timing caveat Tony Luck
2026-09-29  0:29 ` [PATCH v13 00/25] Allow AET to use PMT as loadable module Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928221509.68002-1-tony.luck@intel.com \
    --to=tony.luck@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=david.e.box@intel.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghuay@nvidia.com \
    --cc=hch@infradead.org \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®