From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: akpm@linux-foundation.org, rppt@kernel.org, peterx@redhat.com,
surenb@google.com, aarcange@redhat.com, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, mhocko@suse.com,
shuah@kernel.org, kirill@shutemov.name, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
donggeunyoo.kernel@gmail.com
Subject: Re: [PATCH v3 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry
Date: Tue, 29 Sep 2026 09:20:19 +0900 [thread overview]
Message-ID: <20260929002019.1847080-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <cc123233-5b48-4069-8f84-f95301a83dcf@kernel.org>
On Mon, 28 Sep 2026 11:11:50 +0200, David Hildenbrand (Arm) wrote:
> Why not combine it with the protection?
Will do.
> Why not do that at the very top?
Will do.
> You can set that all already when initializing aboce
Will do.
> BTW, why do we fail the entire test here instead of only this test case?
I did that because the test is about the bit after the move, not the move
itself, so a failing move is closer to a setup failure. I thought it was
better to stop there and let whoever runs it check their environment
before running the rest.
But having gone through the file's history, I see the direction has been
to skip or fail just that one test and keep the rest running. I'll change
it in v4.
Thanks for the review!
Donggeun
prev parent reply other threads:[~2026-09-29 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 12:41 [PATCH v3 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte() Donggeun Yoo
2026-09-26 12:41 ` [PATCH v3 1/2] " Donggeun Yoo
2026-09-27 20:54 ` Andrew Morton
2026-09-28 7:33 ` David Hildenbrand (Arm)
2026-09-26 12:41 ` [PATCH v3 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry Donggeun Yoo
2026-09-28 8:53 ` David Hildenbrand (Arm)
2026-09-28 8:53 ` David Hildenbrand (Arm)
2026-09-28 9:11 ` David Hildenbrand (Arm)
2026-09-29 0:20 ` Donggeun Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929002019.1847080-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=kirill@shutemov.name \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®