mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: luoliang@kylinos.cn
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
	Liang Luo <luoliang@kylinos.cn>
Subject: Re: [PATCH] sched_ext: Count cap-rejected local DSQ inserts in SCX_EV_SUB_REJECT
Date: Tue, 29 Sep 2026 11:00:26 +0800	[thread overview]
Message-ID: <20260929030026.3449491-1-luoliang@kylinos.cn> (raw)
In-Reply-To: <4aed937b9a7376fd50c1e272f9e1f177@kernel.org>

From: Liang Luo <luoliang@kylinos.cn>

Hello Tejun,

Thanks for the review.

On Mon, Sep 28, 2026 at 09:06:21AM -1000, Tejun Heo wrote:
> I have nothing against adding the counter, but we don't count every path,
> so an uncounted branch arm isn't a reason by itself. What's the rationale
> for counting this one?

That's fair - a counter should be justified on its own, not by symmetry
with its siblings. The rationale here is that of the three outcomes, the
reject diversion is the one without preconditions: the other two
require a draining rq, a task that cannot migrate anywhere else, or an
explicit SCX_ENQ_RESCUE opt-in, while every other cap-missing insert
lands in the reject DSQ. With this counter, the events cover all three
outcomes of a cap-missing local insert.

> This doesn't fix a bug. Can you drop the Fixes: tag?

Done in v2.

Thanks.

Liang Luo

  reply	other threads:[~2026-09-29  3:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25  7:05 luoliang
2026-09-28 19:06 ` Tejun Heo
2026-09-29  3:00   ` luoliang [this message]
2026-09-29  3:03 ` [PATCH v2] " luoliang
2026-09-29  5:09   ` Andrea Righi
2026-09-29  6:12     ` luoliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929030026.3449491-1-luoliang@kylinos.cn \
    --to=luoliang@kylinos.cn \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®