From: Tejun Heo <tj@kernel.org>
To: Liang Luo <luoliang@kylinos.cn>
Cc: David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Count cap-rejected local DSQ inserts in SCX_EV_SUB_REJECT
Date: Mon, 28 Sep 2026 09:06:21 -1000 [thread overview]
Message-ID: <4aed937b9a7376fd50c1e272f9e1f177@kernel.org> (raw)
In-Reply-To: <20260925070500.565561-1-luoliang@kylinos.cn>
Hello, Liang.
On Fri, Sep 25, 2026 at 03:05:00PM +0800, luoliang@kylinos.cn wrote:
> The first two are counted but the last is not, so the number of tasks
> diverted to the reject DSQ is missing from the counters exposed via
> sysfs, scx_dump_state() and the scx_bpf_events() kfunc.
I have nothing against adding the counter, but we don't count every path,
so an uncounted branch arm isn't a reason by itself. What's the rationale
for counting this one?
> Fixes: 75a8c8202c91 ("sched_ext: Add reject DSQ for cap-rejected dispatches")
This doesn't fix a bug. Can you drop the Fixes: tag?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-09-28 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 7:05 luoliang
2026-09-28 19:06 ` Tejun Heo [this message]
2026-09-29 3:00 ` luoliang
2026-09-29 3:03 ` [PATCH v2] " luoliang
2026-09-29 5:09 ` Andrea Righi
2026-09-29 6:12 ` luoliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aed937b9a7376fd50c1e272f9e1f177@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoliang@kylinos.cn \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®