From: Tao Cui <cui.tao@linux.dev>
To: maobibo@loongson.cn, gaosong@loongson.cn, zhaotianrui@loongson.cn
Cc: loongarch@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, nagachaithanya9911@gmail.com,
cui.tao@linux.dev, Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH v2 0/4] LoongArch: KVM: irqchip fixes
Date: Tue, 29 Sep 2026 18:28:17 +0800 [thread overview]
Message-ID: <20260929102821.36112-1-cui.tao@linux.dev> (raw)
From: Tao Cui <cuitao@kylinos.cn>
Hi,
Four fixes for the LoongArch KVM irqchip code:
- Patch 1 clears the device pointer in the destroy callbacks: when
KVM_CREATE_DEVICE succeeds but the following fd allocation fails
(e.g. under RLIMIT_NOFILE), ops->destroy() frees the irqchip while
kvm->arch.* still points to it.
- Patch 2 loads kvm->arch.dmsintc once in the MSI injection path:
pch_msi_set_irq() re-reads the pointer between the non-NULL check
and the address-window comparison, so a concurrent device removal
can be observed between them.
- Patch 3 aligns kvm_pch_pic_create() with kvm_eiointc_create() by
propagating the real error code; the kvm_ipi_create() counterpart is
being fixed separately (Chaithanya Lagisetty).
- Patch 4 rejects repeated PCH-PIC CTRL_INIT with -EEXIST, tracking
the state with a has_init flag so the check and the MMIO base update
are atomic under slots_lock.
All patches carry Fixes tags.
Changes in v2:
- Drop "Guard against NULL irqchip in irq injection" (v1 patch 2) and
"Rebase steal time counter in vcpu context" (v1 patch 4) after
review discussion: their trigger scenarios are not reachable
through real VMM behaviour.
- Use the one-line destroy style in dmsintc suggested by Bibo.
- Track repeated PCH-PIC CTRL_INIT with a has_init flag and return
-EEXIST instead of -EBUSY, also suggested by Bibo; move the check
and base update under slots_lock so they are atomic.
- Add READ_ONCE() to the dmsintc pointer loads so the compiler
keeps each of them a single load.
Tao Cui (4):
LoongArch: KVM: Clear device pointer in irqchip destroy callbacks
LoongArch: KVM: Load dmsintc pointer once in pch_msi_set_irq
LoongArch: KVM: Propagate real error code in kvm_pch_pic_create
LoongArch: KVM: Reject repeated PCH-PIC CTRL_INIT
arch/loongarch/include/asm/kvm_pch_pic.h | 1 +
arch/loongarch/kvm/intc/dmsintc.c | 7 ++++++-
arch/loongarch/kvm/intc/eiointc.c | 1 +
arch/loongarch/kvm/intc/ipi.c | 1 +
arch/loongarch/kvm/intc/pch_pic.c | 22 ++++++++++++++++------
5 files changed, 25 insertions(+), 7 deletions(-)
--
2.43.0
next reply other threads:[~2026-09-29 10:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 10:28 Tao Cui [this message]
2026-09-29 10:28 ` [PATCH v2 1/4] LoongArch: KVM: Clear device pointer in irqchip destroy callbacks Tao Cui
2026-09-29 10:28 ` [PATCH v2 2/4] LoongArch: KVM: Load dmsintc pointer once in pch_msi_set_irq Tao Cui
2026-09-30 1:42 ` Bibo Mao
2026-09-30 2:08 ` Huacai Chen
2026-09-30 2:15 ` Bibo Mao
2026-09-29 10:28 ` [PATCH v2 3/4] LoongArch: KVM: Propagate real error code in kvm_pch_pic_create Tao Cui
2026-09-29 10:28 ` [PATCH v2 4/4] LoongArch: KVM: Reject repeated PCH-PIC CTRL_INIT Tao Cui
2026-09-29 12:43 ` Huacai Chen
2026-09-30 1:15 ` Tao Cui
2026-09-30 2:25 ` Huacai Chen
2026-09-30 1:54 ` Bibo Mao
2026-09-30 2:24 ` Huacai Chen
2026-09-30 2:34 ` Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929102821.36112-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=chenhuacai@kernel.org \
--cc=cuitao@kylinos.cn \
--cc=gaosong@loongson.cn \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=nagachaithanya9911@gmail.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®