* [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property
@ 2026-09-29 10:41 Arnd Bergmann
2026-09-29 12:46 ` Abel Vesa
2026-09-29 12:58 ` Konrad Dybcio
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-09-29 10:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Monish Chunara
Cc: Arnd Bergmann, Abel Vesa, Dmitry Baryshkov, Komal Bajaj,
Imran Shaik, Nihal Kumar Gupta, Bibek Kumar Patro, Jie Gan,
Xueyao An, Gaurav Kohli, linux-arm-msm, devicetree, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The gicv3 on this chip uses a 4-cell interrupt specifier, which
includes the affinity, but the newly added mmc node uses the
3-cell format:
arch/arm64/boot/dts/qcom/shikra.dtsi:4151.4-27: Warning (interrupts_property): /soc@0/mmc@4784000:#interrupt-cells: size is (24), expected multiple of 16
Add a zero affinity, same as for the other I/O devices on this chip.
Fixes: c8e3d40457f1 ("arm64: dts: qcom: shikra: Add SD Card support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/boot/dts/qcom/shikra.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
index 9823c591b02b..1814ab33e236 100644
--- a/arch/arm64/boot/dts/qcom/shikra.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
@@ -1470,8 +1470,8 @@ sdhc_2: mmc@4784000 {
compatible = "qcom,shikra-sdhci", "qcom,sdhci-msm-v5";
reg = <0x0 0x04784000 0x0 0x1000>;
- interrupts = <GIC_SPI 350 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 350 IRQ_TYPE_LEVEL_HIGH 0>,
+ <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH 0>;
interrupt-names = "hc_irq",
"pwr_irq";
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property
2026-09-29 10:41 [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property Arnd Bergmann
@ 2026-09-29 12:46 ` Abel Vesa
2026-09-29 12:58 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2026-09-29 12:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Monish Chunara, Arnd Bergmann, Abel Vesa,
Dmitry Baryshkov, Komal Bajaj, Imran Shaik, Nihal Kumar Gupta,
Bibek Kumar Patro, Jie Gan, Xueyao An, Gaurav Kohli,
linux-arm-msm, devicetree, linux-kernel
On 26-09-29 12:41:12, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The gicv3 on this chip uses a 4-cell interrupt specifier, which
> includes the affinity, but the newly added mmc node uses the
> 3-cell format:
>
> arch/arm64/boot/dts/qcom/shikra.dtsi:4151.4-27: Warning (interrupts_property): /soc@0/mmc@4784000:#interrupt-cells: size is (24), expected multiple of 16
>
> Add a zero affinity, same as for the other I/O devices on this chip.
>
> Fixes: c8e3d40457f1 ("arm64: dts: qcom: shikra: Add SD Card support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property
2026-09-29 10:41 [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property Arnd Bergmann
2026-09-29 12:46 ` Abel Vesa
@ 2026-09-29 12:58 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-09-29 12:58 UTC (permalink / raw)
To: Arnd Bergmann, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Monish Chunara
Cc: Arnd Bergmann, Abel Vesa, Dmitry Baryshkov, Komal Bajaj,
Imran Shaik, Nihal Kumar Gupta, Bibek Kumar Patro, Jie Gan,
Xueyao An, Gaurav Kohli, linux-arm-msm, devicetree, linux-kernel
On 9/29/26 12:41 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The gicv3 on this chip uses a 4-cell interrupt specifier, which
> includes the affinity, but the newly added mmc node uses the
> 3-cell format:
>
> arch/arm64/boot/dts/qcom/shikra.dtsi:4151.4-27: Warning (interrupts_property): /soc@0/mmc@4784000:#interrupt-cells: size is (24), expected multiple of 16
>
> Add a zero affinity, same as for the other I/O devices on this chip.
>
> Fixes: c8e3d40457f1 ("arm64: dts: qcom: shikra: Add SD Card support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-29 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-29 10:41 [PATCH] arm64: dts: qcom: shikra: fix sdhc interrupts property Arnd Bergmann
2026-09-29 12:46 ` Abel Vesa
2026-09-29 12:58 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®