From: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
To: jic23@kernel.org, gregkh@linuxfoundation.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com
Cc: dlechner@baylibre.com, andy@kernel.org, linux@analog.com,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, joshua.crofts1@gmail.com,
error27@gmail.com, narcisaanamaria12@gmail.com,
Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Subject: [PATCH 3/3] staging: iio: accel: adis16203: clean up register definitions and drop redundant comments
Date: Tue, 29 Sep 2026 21:49:00 +0300 [thread overview]
Message-ID: <20260929184900.39515-4-abdelnasserhussein11@gmail.com> (raw)
In-Reply-To: <20260929184900.39515-1-abdelnasserhussein11@gmail.com>
Drop redundant, single-line comments above register macros that provide
no additional value.
Vertically align the macro values with tabs to improve readability and
conform to standard kernel coding style.
Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
---
drivers/staging/iio/accel/adis16203.c | 87 ++++-----------------------
1 file changed, 13 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 905485fd556f..b0fa2701cbd1 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -17,105 +17,44 @@
#define ADIS16203_STARTUP_DELAY 220 /* ms */
-/* Flash memory write count */
#define ADIS16203_FLASH_CNT 0x00
-
-/* Output, power supply */
#define ADIS16203_SUPPLY_OUT 0x02
-
-/* Output, auxiliary ADC input */
#define ADIS16203_AUX_ADC 0x08
-
-/* Output, temperature */
#define ADIS16203_TEMP_OUT 0x0A
-
-/* Output, x-axis inclination */
#define ADIS16203_INCL_OUT 0x0C
-
-/* Incline null calibration */
#define ADIS16203_INCL_NULL 0x18
-
-/* Alarm 1 amplitude threshold */
#define ADIS16203_ALM_MAG1 0x20
-
-/* Alarm 2 amplitude threshold */
#define ADIS16203_ALM_MAG2 0x22
-
-/* Alarm 1, sample period */
#define ADIS16203_ALM_SMPL1 0x24
-
-/* Alarm 2, sample period */
#define ADIS16203_ALM_SMPL2 0x26
-
-/* Alarm control */
#define ADIS16203_ALM_CTRL 0x28
-
-/* Auxiliary DAC data */
#define ADIS16203_AUX_DAC 0x30
-
-/* General-purpose digital input/output control */
#define ADIS16203_GPIO_CTRL 0x32
-
-/* Miscellaneous control */
#define ADIS16203_MSC_CTRL 0x34
-
-/* Internal sample period (rate) control */
#define ADIS16203_SMPL_PRD 0x36
-
-/* Operation, filter configuration */
#define ADIS16203_AVG_CNT 0x38
-
-/* Operation, sleep mode control */
#define ADIS16203_SLP_CNT 0x3A
-
-/* Diagnostics, system status register */
#define ADIS16203_DIAG_STAT 0x3C
-
-/* Operation, system command register */
#define ADIS16203_GLOB_CMD 0x3E
/* MSC_CTRL */
-/* Self-test at power-on: 1 = disabled, 0 = enabled */
-#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST BIT(10)
-
-/* Reverses rotation of both inclination outputs */
-#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN BIT(9)
-
-/* Self-test enable */
-#define ADIS16203_MSC_CTRL_SELF_TEST_EN BIT(8)
-
-/* Data-ready enable: 1 = enabled, 0 = disabled */
-#define ADIS16203_MSC_CTRL_DATA_RDY_EN BIT(2)
-
-/* Data-ready polarity: 1 = active high, 0 = active low */
-#define ADIS16203_MSC_CTRL_ACTIVE_HIGH BIT(1)
-
-/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
-#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 BIT(0)
+#define ADIS16203_MSC_CTRL_PWRUP_SELF_TEST BIT(10)
+#define ADIS16203_MSC_CTRL_REVERSE_ROT_EN BIT(9)
+#define ADIS16203_MSC_CTRL_SELF_TEST_EN BIT(8)
+#define ADIS16203_MSC_CTRL_DATA_RDY_EN BIT(2)
+#define ADIS16203_MSC_CTRL_ACTIVE_HIGH BIT(1)
+#define ADIS16203_MSC_CTRL_DATA_RDY_DIO1 BIT(0)
/* DIAG_STAT */
-/* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_ALARM2 BIT(9)
-
-/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
-#define ADIS16203_DIAG_STAT_ALARM1 BIT(8)
-
-/* Self-test diagnostic error flag */
-#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5
-
-/* SPI communications failure */
-#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3
-
-/* Flash update failure */
-#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2
-
-/* Power supply above 3.625 V */
-#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1
-
-/* Power supply below 2.975 V */
-#define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0
+#define ADIS16203_DIAG_STAT_ALARM2 BIT(9)
+#define ADIS16203_DIAG_STAT_ALARM1 BIT(8)
+#define ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT 5
+#define ADIS16203_DIAG_STAT_SPI_FAIL_BIT 3
+#define ADIS16203_DIAG_STAT_FLASH_UPT_BIT 2
+#define ADIS16203_DIAG_STAT_POWER_HIGH_BIT 1
+#define ADIS16203_DIAG_STAT_POWER_LOW_BIT 0
/* GLOB_CMD */
--
2.54.0
next prev parent reply other threads:[~2026-09-29 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 18:48 [PATCH 0/3] staging: iio: accel: adis16203: fix axis mapping and cleanups Abdelnasser Hussein
2026-09-29 18:48 ` [PATCH 1/3] staging: iio: accel: adis16203: fix inclination naming and remove unsupported Y-axis Abdelnasser Hussein
2026-09-30 8:24 ` Joshua Crofts
2026-09-30 9:21 ` Andy Shevchenko
2026-09-30 11:34 ` nasser
2026-09-29 18:48 ` [PATCH 2/3] staging: iio: accel: adis16203: add missing spi_device_id table Abdelnasser Hussein
2026-09-30 6:56 ` Joshua Crofts
2026-09-30 11:35 ` nasser
2026-09-29 18:49 ` Abdelnasser Hussein [this message]
2026-09-30 7:04 ` [PATCH 3/3] staging: iio: accel: adis16203: clean up register definitions and drop redundant comments Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929184900.39515-4-abdelnasserhussein11@gmail.com \
--to=abdelnasserhussein11@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=narcisaanamaria12@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®