[PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

[PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

[John Hubbard]

This is a high value thing to print, because it acts as kind of a
bookend, showing the beginning of trying to boot up.

Cc: Danilo Krummrich <dakr@kernel.org>
Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---

Changes in v2: moved the print statement outside of try_pin_init!().


 drivers/gpu/nova-core/driver.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
index 291a047e4d86..623d59dcde6e 100644
--- a/drivers/gpu/nova-core/driver.rs
+++ b/drivers/gpu/nova-core/driver.rs
@@ -100,6 +100,8 @@ fn probe<'bound>(
         pdev: &'bound pci::Device<Core<'_>>,
         _info: Option<&'bound Self::IdInfo>,
     ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
+        dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
+
         try_pin_init!(NovaCore {
             _: {
                 pdev.enable_device_mem()?;

base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
-- 
2.55.0

Re: [PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

[John Hubbard]

On 9/29/26 2:07 PM, John Hubbard wrote:
> This is a high value thing to print, because it acts as kind of a
> bookend, showing the beginning of trying to boot up.
> 
> Cc: Danilo Krummrich <dakr@kernel.org>
> Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"

There is a trailing " at the end of that Fixes line. Even though I
ran checkpatch.pl on both of these patch versions, it didn't flag
it.

> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> 
> Changes in v2: moved the print statement outside of try_pin_init!().
> 
> 
>  drivers/gpu/nova-core/driver.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
> index 291a047e4d86..623d59dcde6e 100644
> --- a/drivers/gpu/nova-core/driver.rs
> +++ b/drivers/gpu/nova-core/driver.rs
> @@ -100,6 +100,8 @@ fn probe<'bound>(
>          pdev: &'bound pci::Device<Core<'_>>,
>          _info: Option<&'bound Self::IdInfo>,
>      ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
> +        dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
> +
>          try_pin_init!(NovaCore {
>              _: {
>                  pdev.enable_device_mem()?;
> 
> base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d

thanks,
-- 
John Hubbard

Re: [PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

[Danilo Krummrich]

On Tue Sep 29, 2026 at 11:34 PM CEST, John Hubbard wrote:
> There is a trailing " at the end of that Fixes line. Even though I
> ran checkpatch.pl on both of these patch versions, it didn't flag
> it.

Thanks, I can drop it then. (Though, I'm not sure this should have a Fixes: tag
in the first place.)

Re: [PATCH v2] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print

[John Hubbard]

On 9/29/26 2:46 PM, Danilo Krummrich wrote:
> On Tue Sep 29, 2026 at 11:34 PM CEST, John Hubbard wrote:
>> There is a trailing " at the end of that Fixes line. Even though I
>> ran checkpatch.pl on both of these patch versions, it didn't flag
>> it.
> 
> Thanks, I can drop it then. (Though, I'm not sure this should have a Fixes: tag
> in the first place.)

We can just omit the entire Fixes line, yes. It's not fixing a bug
or anything, that's true.

thanks,
-- 
John Hubbard