mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>, Shuah Khan <shuah@kernel.org>,
	David Ahern <dsahern@kernel.org>,
	Zhu Yanjun <yanjun.zhu@linux.dev>, Jiri Pirko <jiri@resnulli.us>,
	linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/selftests: Fix the kernel config fragment
Date: Tue, 29 Sep 2026 20:00:09 -0300	[thread overview]
Message-ID: <20260929230009.GC2446731@nvidia.com> (raw)
In-Reply-To: <20260927161655.1184153-1-sashal@kernel.org>

On Sun, Sep 27, 2026 at 12:16:54PM -0400, Sasha Levin wrote:
> The config fragment lists bare option names with no values:
> 
>   CONFIG_TUN
>   CONFIG_VETH
>   CONFIG_DUMMY
>   CONFIG_NET_NS
>   CONFIG_RDMA_RXE
> 
> which is not valid Kconfig syntax. When the fragment is merged, for
> example by "make kselftest-merge" or by CI systems, the lines are
> rejected:
> 
>   .config:5514:warning: unexpected data: CONFIG_TUN
>   .config:5515:warning: unexpected data: CONFIG_VETH
>   .config:5516:warning: unexpected data: CONFIG_DUMMY
> 
> and none of the options gets enabled, so the rxe tests skip or fail
> for lack of the modules they load.
> 
> Give each option a value. The scripts load and unload tun, veth,
> dummy and rdma_rxe with modprobe, so build those as modules.
> RDMA_RXE also depends on INFINIBAND, and rxe_rping_between_netns.sh
> runs rping, which needs the RDMA CM userspace interface provided by
> INFINIBAND_USER_ACCESS, so add both.
> 
> Found by KernelCI kselftest builds.
> 
> Fixes: e01027cab38a ("RDMA/rxe: Add testcase for net namespace rxe")
> Fixes: ecdcc8a455b7 ("RDMA/selftests: Add rxe_netns_names test")
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>  tools/testing/selftests/rdma/config | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Applied to for-next, thanks

Jason

      parent reply	other threads:[~2026-09-29 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 16:16 Sasha Levin
2026-09-28  3:50 ` Zhu Yanjun
2026-09-29 23:00 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929230009.GC2446731@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dsahern@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®