Re: [PATCH] RDMA/selftests: Fix the kernel config fragment

[Zhu Yanjun <yanjun.zhu@linux.dev>]

在 2026/9/27 9:16, Sasha Levin 写道:
> The config fragment lists bare option names with no values:
>
>    CONFIG_TUN
>    CONFIG_VETH
>    CONFIG_DUMMY
>    CONFIG_NET_NS
>    CONFIG_RDMA_RXE
>
> which is not valid Kconfig syntax. When the fragment is merged, for
> example by "make kselftest-merge" or by CI systems, the lines are
> rejected:
>
>    .config:5514:warning: unexpected data: CONFIG_TUN
>    .config:5515:warning: unexpected data: CONFIG_VETH
>    .config:5516:warning: unexpected data: CONFIG_DUMMY
>
> and none of the options gets enabled, so the rxe tests skip or fail
> for lack of the modules they load.
>
> Give each option a value. The scripts load and unload tun, veth,
> dummy and rdma_rxe with modprobe, so build those as modules.
> RDMA_RXE also depends on INFINIBAND, and rxe_rping_between_netns.sh
> runs rping, which needs the RDMA CM userspace interface provided by
> INFINIBAND_USER_ACCESS, so add both.
>
> Found by KernelCI kselftest builds.
>
> Fixes: e01027cab38a ("RDMA/rxe: Add testcase for net namespace rxe")
> Fixes: ecdcc8a455b7 ("RDMA/selftests: Add rxe_netns_names test")
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>

The fix looks correct. The existing entries in 
tools/testing/selftests/rdma/config are

not valid config fragment assignments and are rejected by kselftest-merge.

Using m for the modules loaded by the RXE netns tests is appropriate,

while NET_NS=y provides the required network namespace support.

Adding INFINIBAND and INFINIBAND_USER_ACCESS also matches

the RXE/rping runtime dependencies.

Thanks a lot.

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Zhu Yanjun

> ---
>   tools/testing/selftests/rdma/config | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/rdma/config b/tools/testing/selftests/rdma/config
> index e1ff54ec0f579..1be43c4274bb8 100644
> --- a/tools/testing/selftests/rdma/config
> +++ b/tools/testing/selftests/rdma/config
> @@ -1,5 +1,7 @@
> -CONFIG_TUN
> -CONFIG_VETH
> -CONFIG_DUMMY
> -CONFIG_NET_NS
> -CONFIG_RDMA_RXE
> +CONFIG_TUN=m
> +CONFIG_VETH=m
> +CONFIG_DUMMY=m
> +CONFIG_NET_NS=y
> +CONFIG_INFINIBAND=m
> +CONFIG_INFINIBAND_USER_ACCESS=m
> +CONFIG_RDMA_RXE=m

-- 
Best Regards,
Yanjun.Zhu