[PATCH] rust: block: implement `Send` and `Sync` for `TagSet`

[PATCH] rust: block: implement `Send` and `Sync` for `TagSet`

[Andreas Hindborg]

`TagSet` never implemented `Send` or `Sync`. This did not matter until
commit "rust: block: fix `Send` bound for `GenDisk`" made `GenDisk: Send`
depend on `Arc<TagSet<T>>: Send`, which in turn requires `TagSet<T>: Send +
Sync`. With that bound unsatisfiable, `GenDisk` is never `Send`, and the
rnull driver fails to build once configfs requires `GroupOperations::Child:
Send`.

`TagSet` owns no data typed by `T`. It only wraps the C `struct
blk_mq_tag_set`, which can be dropped from any thread by calling
`blk_mq_free_tag_set`. Thus, implement `Send` and `Sync` for `TagSet`
unconditionally.

Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Closes: https://lore.kernel.org/r/d1381ed8-eab8-4fd7-8b15-1e94876d7099@leemhuis.info
Suggested-by: Gary Guo <gary@garyguo.net>
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
Hi Jens,

Please pick this patch to resolve a problematic rust configfs/block
interaction in linux-next [1].

Best regards,
Andreas Hindborg

[1] https://lore.kernel.org/r/d1381ed8-eab8-4fd7-8b15-1e94876d7099@leemhuis.info
---
 rust/kernel/block/mq/tag_set.rs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/rust/kernel/block/mq/tag_set.rs b/rust/kernel/block/mq/tag_set.rs
index dae9df408a86..00d29688f920 100644
--- a/rust/kernel/block/mq/tag_set.rs
+++ b/rust/kernel/block/mq/tag_set.rs
@@ -83,3 +83,10 @@ fn drop(self: Pin<&mut Self>) {
         unsafe { bindings::blk_mq_free_tag_set(self.inner.get()) };
     }
 }
+
+// SAFETY: It is safe to transfer ownership of `TagSet` between threads.
+unsafe impl<T: Operations> Send for TagSet<T> {}
+
+// SAFETY: It is safe to share `&TagSet` across threads. `TagSet` exposes no
+// `&self` methods that mutate the contained `blk_mq_tag_set`.
+unsafe impl<T: Operations> Sync for TagSet<T> {}

---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260930-tag-set-send-sync-c4d64515e1e0

Best regards,
--  
Andreas Hindborg <a.hindborg@kernel.org>

Re: [PATCH] rust: block: implement `Send` and `Sync` for `TagSet`

[Alice Ryhl]

On Wed, Sep 30, 2026 at 9:44 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
> `TagSet` never implemented `Send` or `Sync`. This did not matter until
> commit "rust: block: fix `Send` bound for `GenDisk`" made `GenDisk: Send`
> depend on `Arc<TagSet<T>>: Send`, which in turn requires `TagSet<T>: Send +
> Sync`. With that bound unsatisfiable, `GenDisk` is never `Send`, and the
> rnull driver fails to build once configfs requires `GroupOperations::Child:
> Send`.
>
> `TagSet` owns no data typed by `T`. It only wraps the C `struct
> blk_mq_tag_set`, which can be dropped from any thread by calling
> `blk_mq_free_tag_set`. Thus, implement `Send` and `Sync` for `TagSet`
> unconditionally.
>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/r/d1381ed8-eab8-4fd7-8b15-1e94876d7099@leemhuis.info
> Suggested-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust: block: implement `Send` and `Sync` for `TagSet`

[Thorsten Leemhuis]

On 9/30/26 21:43, Andreas Hindborg wrote:
> `TagSet` never implemented `Send` or `Sync`. This did not matter until
> commit "rust: block: fix `Send` bound for `GenDisk`" made `GenDisk: Send`
> depend on `Arc<TagSet<T>>: Send`, which in turn requires `TagSet<T>: Send +
> Sync`. With that bound unsatisfiable, `GenDisk` is never `Send`, and the
> rnull driver fails to build once configfs requires `GroupOperations::Child:
> Send`.
> 
> `TagSet` owns no data typed by `T`. It only wraps the C `struct
> blk_mq_tag_set`, which can be dropped from any thread by calling
> `blk_mq_free_tag_set`. Thus, implement `Send` and `Sync` for `TagSet`
> unconditionally.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/r/d1381ed8-eab8-4fd7-8b15-1e94876d7099@leemhuis.info

Thx, this fixes is for me! Just in case anyone cares:

Tested-by: Thorsten Leemhuis <linux@leemhuis.info>

Ciao, Thorsten

Re: [PATCH] rust: block: implement `Send` and `Sync` for `TagSet`

[Jens Axboe]

On Wed, 30 Sep 2026 21:43:55 +0200, Andreas Hindborg wrote:
> `TagSet` never implemented `Send` or `Sync`. This did not matter until
> commit "rust: block: fix `Send` bound for `GenDisk`" made `GenDisk: Send`
> depend on `Arc<TagSet<T>>: Send`, which in turn requires `TagSet<T>: Send +
> Sync`. With that bound unsatisfiable, `GenDisk` is never `Send`, and the
> rnull driver fails to build once configfs requires `GroupOperations::Child:
> Send`.
> 
> [...]

Applied, thanks!

[1/1] rust: block: implement `Send` and `Sync` for `TagSet`
      commit: 06dad60393f20985cc5f24eeed63f965d366c4a0

Best regards,
-- 
Jens Axboe