From: Hui Peng <benquike@gmail.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Hui Peng <benquike@gmail.com>
Subject: [PATCH v6 2/3] serial: core: fix baud rate fallback in uart_get_baud_rate()
Date: Wed, 30 Sep 2026 07:48:49 +0000 [thread overview]
Message-ID: <20260930074850.465003-3-benquike@gmail.com> (raw)
In-Reply-To: <20260930074850.465003-1-benquike@gmail.com>
In uart_get_baud_rate(), when a custom divisor is requested, if
port->uartclk is zero, the fallback logic evaluates baud = port->uartclk / 16
which results in baud = 0, causing a divide-by-zero error in subsequent
calculations.
Ensure uart_get_baud_rate() falls back to a valid default baud rate when
port->uartclk is zero.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Assisted-by: LLM
Signed-off-by: Hui Peng <benquike@gmail.com>
---
drivers/tty/serial/serial_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 95774b0f1484..55bb1eaa27e7 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -480,6 +480,11 @@ uart_get_baud_rate(struct uart_port *port, struct ktermios *termios,
return 0;
max = port->uartclk / 16;
+ if (!max)
+ max = 115200;
+
if (termios) {
baud = tty_termios_baud_rate(termios);
next prev parent reply other threads:[~2026-09-30 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 7:48 [PATCH v6 0/3] serial: fix IRQ chain race, baud fallback, and uartclk overflow Hui Peng
2026-09-30 7:48 ` [PATCH v6 1/3] serial: 8250: fix deadlock in serial8250_register_ports() Hui Peng
2026-09-30 7:56 ` Ilpo Järvinen
2026-09-30 10:00 ` Andy Shevchenko
2026-09-30 7:48 ` Hui Peng [this message]
2026-09-30 7:48 ` [PATCH v6 3/3] serial: core: reject baud_base values that overflow port->uartclk in uart_set_info() Hui Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930074850.465003-3-benquike@gmail.com \
--to=benquike@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®