From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hui Peng <benquike@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v6 1/3] serial: 8250: fix deadlock in serial8250_register_ports()
Date: Wed, 30 Sep 2026 13:00:18 +0300 [thread overview]
Message-ID: <arzdsky5fd5TbSap@ashevche-desk.local> (raw)
In-Reply-To: <20260930074850.465003-2-benquike@gmail.com>
On Wed, Sep 30, 2026 at 07:48:48AM +0000, Hui Peng wrote:
> In serial8250_register_ports(), mutex_lock(&hash_mutex) is acquired while
> holding spinlock_t serial_port_lock during IRQ chain registration:
>
> spin_lock_irqsave(&serial_port_lock, flags);
> mutex_lock(&hash_mutex);
>
> Acquiring a sleeping mutex while holding a spinlock causes a
> sleeping-while-atomic bug and potential deadlock.
>
> Replace mutex_lock(&hash_mutex) with spin_lock_irqsave() in
> serial8250_register_ports().
> Cc: stable@vger.kernel.org
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Assisted-by: LLM
> Signed-off-by: Hui Peng <benquike@gmail.com>
...
> for (i = 0; i < nr; i++) {
> - up = &serial8250_ports[i];
> + up = &serial8250_ports[i];
> up->port.dev = dev;
> }
What the heck is this?! Please, stop use AI blindly, turn on your brains.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-30 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 7:48 [PATCH v6 0/3] serial: fix IRQ chain race, baud fallback, and uartclk overflow Hui Peng
2026-09-30 7:48 ` [PATCH v6 1/3] serial: 8250: fix deadlock in serial8250_register_ports() Hui Peng
2026-09-30 7:56 ` Ilpo Järvinen
2026-09-30 10:00 ` Andy Shevchenko [this message]
2026-09-30 7:48 ` [PATCH v6 2/3] serial: core: fix baud rate fallback in uart_get_baud_rate() Hui Peng
2026-09-30 7:48 ` [PATCH v6 3/3] serial: core: reject baud_base values that overflow port->uartclk in uart_set_info() Hui Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arzdsky5fd5TbSap@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=benquike@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®