From: "Ali Ahmet Memiş" <aliamemis@disroot.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Hans de Goede <hansg@kernel.org>,
Nitin Joshi <nitjoshi@gmail.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Use input_device_enabled()
Date: Wed, 30 Sep 2026 10:58:29 +0300 [thread overview]
Message-ID: <20260930075829.53484-1-aliamemis@disroot.org> (raw)
In-Reply-To: <178947195441.31094.9793704324340226838.b4-ty@b4>
On Tue, Sep 15, 2026 at 02:32:34PM +0300, Ilpo Järvinen wrote:
> [1/1] platform/x86: thinkpad_acpi: Use input_device_enabled()
> commit: be0048786d53375fa4eace15cfdf65593956a1a2
This hangs on module load for me. hotkey_inputdev_open() gets
called from input_open_device() with dev->mutex already held, so the
new lock in hotkey_poll_setup() deadlocks:
INFO: task insmod:28182 is blocked on a mutex likely owned by task insmod:28182.
hotkey_poll_setup+0x50/0x140 [thinkpad_acpi]
hotkey_inputdev_open+0x36/0x50 [thinkpad_acpi]
input_open_device+0x9d/0x130
kbd_connect+0x8f/0xb0
I guess hotkey_inputdev_close() has the same issue. This was
next-20260929's thinkpad_acpi.c built against 7.1.11.
next prev parent reply other threads:[~2026-09-30 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 4:03 Dmitry Torokhov
2026-08-05 14:51 ` Mark Pearson
2026-08-05 15:52 ` Dmitry Torokhov
2026-08-05 16:15 ` Mark Pearson
2026-08-06 6:20 ` Dmitry Torokhov
2026-09-15 11:32 ` Ilpo Järvinen
2026-09-30 7:58 ` Ali Ahmet Memiş [this message]
2026-09-30 19:37 ` Dmitry Torokhov
2026-09-30 20:00 ` Ali Ahmet Memiş
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930075829.53484-1-aliamemis@disroot.org \
--to=aliamemis@disroot.org \
--cc=andrzej.p@collabora.com \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=nitjoshi@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®