From: Thierry Chatard <tchatard@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: hansg@kernel.org, lee@kernel.org,
platform-driver-x86@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, djrscally@gmail.com,
dan.scally@ideasonboard.com, linux-media@vger.kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
jacopo.mondi@ideasonboard.com, nicholas@rothemail.net,
andriy.shevchenko@intel.com, v.vitovt@gmail.com,
dmanresa@gmail.com, Thierry Chatard <tchatard@gmail.com>
Subject: [PATCH v11 6/9] platform/x86: int3472: tps68470: use a common always-on VIO regulator init_data
Date: Wed, 30 Sep 2026 14:43:18 -0700 [thread overview]
Message-ID: <20260930214321.600863-7-tchatard@gmail.com> (raw)
In-Reply-To: <20260930214321.600863-1-tchatard@gmail.com>
The surface_go and intel_nvl board data define byte-identical VIO
regulator init_data (1.8006 V, apply_uV, always_on). Replace both with a
single shared common_tps68470_vio_reg_init_data so new boards with the
same requirement can reuse it instead of duplicating the definition.
No functional change.
Assisted-by: Claude Code:claude-opus-4-8
Signed-off-by: Thierry Chatard <tchatard@gmail.com>
---
.../x86/intel/int3472/tps68470_board_data.c | 21 +++++++------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
index c53542465..c2ec802fc 100644
--- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
+++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
@@ -75,8 +75,12 @@ static const struct regulator_init_data surface_go_tps68470_vcm_reg_init_data =
.consumer_supplies = int347a_vcm_consumer_supplies,
};
-/* Ensure the always-on VIO regulator has the same voltage as VSIO */
-static const struct regulator_init_data surface_go_tps68470_vio_reg_init_data = {
+/*
+ * Common always-on VIO regulator init_data. Its voltage must match VSIO;
+ * boards using the TPS68470 I2C pass-through that need this exact setting
+ * can share this instead of defining their own.
+ */
+static const struct regulator_init_data common_tps68470_vio_reg_init_data = {
.constraints = {
.min_uV = 1800600,
.max_uV = 1800600,
@@ -123,7 +127,7 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata =
[TPS68470_CORE] = &surface_go_tps68470_core_reg_init_data,
[TPS68470_ANA] = &surface_go_tps68470_ana_reg_init_data,
[TPS68470_VCM] = &surface_go_tps68470_vcm_reg_init_data,
- [TPS68470_VIO] = &surface_go_tps68470_vio_reg_init_data,
+ [TPS68470_VIO] = &common_tps68470_vio_reg_init_data,
[TPS68470_VSIO] = &surface_go_tps68470_vsio_reg_init_data,
[TPS68470_AUX1] = &surface_go_tps68470_aux1_reg_init_data,
[TPS68470_AUX2] = &surface_go_tps68470_aux2_reg_init_data,
@@ -339,15 +343,6 @@ static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = {
.consumer_supplies = ovti13b1_vcm_consumer_supplies,
};
-/* Ensure the always-on VIO regulator has the same voltage as VSIO */
-static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = {
- .constraints = {
- .min_uV = 1800600,
- .max_uV = 1800600,
- .apply_uV = true,
- .always_on = true,
- },
-};
static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = {
.constraints = {
.min_uV = 1800600,
@@ -364,7 +359,7 @@ static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata =
[TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data,
[TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data,
[TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data,
- [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data,
+ [TPS68470_VIO] = &common_tps68470_vio_reg_init_data,
[TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data,
},
};
--
2.53.0
next prev parent reply other threads:[~2026-09-30 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 21:43 [PATCH v11 0/9] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 1/9] mfd: intel-lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 2/9] mfd: intel-lpss: add Dell Latitude 7275 to the resource conflict quirk Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 3/9] platform/x86: int3472: tps68470: use unsigned int for GPIO lookup loop counters Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 4/9] platform/x86: int3472: tps68470: move Windows MFD setup below the device-type switch Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 5/9] platform/x86: int3472: tps68470: add static clock consumer support Thierry Chatard
2026-09-30 21:43 ` Thierry Chatard [this message]
2026-09-30 21:43 ` [PATCH v11 7/9] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 8/9] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 9/9] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930214321.600863-7-tchatard@gmail.com \
--to=tchatard@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=dmanresa@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicholas@rothemail.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=v.vitovt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®