* [PATCH v2] clk: tegra: bpmp: remove kcalloc
@ 2026-10-01 5:47 Rosen Penev
2026-10-02 15:46 ` Brian Masney
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-10-01 5:47 UTC (permalink / raw)
To: linux-clk
Cc: Prashant Gaikwad, Stephen Boyd, Brian Masney, Jerome Brunet,
Thierry Reding, Jonathan Hunter, Kees Cook, Gustavo A. R. Silva,
open list:TEGRA ARCHITECTURE SUPPORT, open list,
open list:KERNEL HARDENING (not covered by other
areas):Keyword:b__counted_by(_le|_be|_ptr)?b
Use a flexible array member to avoid allocating separately.
Use __counted_by for extra runtime analysis.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: fix subject
drivers/clk/tegra/clk-bpmp.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index 067a8555c4e7..15b976162b59 100644
--- a/drivers/clk/tegra/clk-bpmp.c
+++ b/drivers/clk/tegra/clk-bpmp.c
@@ -32,7 +32,7 @@ struct tegra_bpmp_clk {
unsigned int id;
unsigned int num_parents;
- unsigned int *parents;
+ unsigned int parents[] __counted_by(num_parents);
};
static inline struct tegra_bpmp_clk *to_tegra_bpmp_clk(struct clk_hw *hw)
@@ -518,20 +518,14 @@ tegra_bpmp_clk_register(struct tegra_bpmp *bpmp,
unsigned int i;
int err;
- clk = devm_kzalloc(bpmp->dev, sizeof(*clk), GFP_KERNEL);
+ clk = devm_kzalloc(bpmp->dev, struct_size(clk, parents, info->num_parents), GFP_KERNEL);
if (!clk)
return ERR_PTR(-ENOMEM);
+ clk->num_parents = info->num_parents;
clk->id = info->id;
clk->bpmp = bpmp;
- clk->parents = devm_kcalloc(bpmp->dev, info->num_parents,
- sizeof(*clk->parents), GFP_KERNEL);
- if (!clk->parents)
- return ERR_PTR(-ENOMEM);
-
- clk->num_parents = info->num_parents;
-
/* hardware clock initialization */
memset(&init, 0, sizeof(init));
init.name = info->name;
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] clk: tegra: bpmp: remove kcalloc
2026-10-01 5:47 [PATCH v2] clk: tegra: bpmp: remove kcalloc Rosen Penev
@ 2026-10-02 15:46 ` Brian Masney
0 siblings, 0 replies; 2+ messages in thread
From: Brian Masney @ 2026-10-02 15:46 UTC (permalink / raw)
To: linux-clk, Rosen Penev
Cc: Prashant Gaikwad, Stephen Boyd, Brian Masney, Jerome Brunet,
Thierry Reding, Jonathan Hunter, Kees Cook, Gustavo A. R. Silva,
linux-tegra, linux-kernel, linux-hardening
On Wed, 30 Sep 2026 22:47:01 -0700, Rosen Penev wrote:
> clk: tegra: bpmp: remove kcalloc
Applied, thanks!
[1/1] clk: tegra: bpmp: remove kcalloc
commit: 2fdfb2abce2fcc157de840949fa3e6af9e915363
Best regards,
--
Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-02 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-01 5:47 [PATCH v2] clk: tegra: bpmp: remove kcalloc Rosen Penev
2026-10-02 15:46 ` Brian Masney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®