mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Archit Anant <architanant5@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
	nuno.sa@analog.com, u.kleine-koenig@baylibre.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 02/10] iio: adc: ti-ads1015: sort headers alphabetically
Date: Thu, 1 Oct 2026 09:08:24 +0200	[thread overview]
Message-ID: <20261001090824.00002477@gmail.com> (raw)
In-Reply-To: <20260930171204.12863-3-architanant5@gmail.com>

On Wed, 30 Sep 2026 22:41:56 +0530
Archit Anant <architanant5@gmail.com> wrote:

> Reorder include headers alphabetically to comply with the preferred
> coding style and improve maintainability.
> 
> No functional changes.
> 
> Signed-off-by: Archit Anant <architanant5@gmail.com>
> ---
>  drivers/iio/adc/ti-ads1015.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 93a165c5416a..ef03b74bda3e 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -11,24 +11,24 @@
>   *	* 0x4B - ADDR connected to SCL
>   */
>  
> -#include <linux/module.h>
>  #include <linux/cleanup.h>
> +#include <linux/delay.h>
> +#include <linux/i2c.h>
>  #include <linux/init.h>
>  #include <linux/irq.h>
> -#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/property.h>
>  #include <linux/regmap.h>
> -#include <linux/pm_runtime.h>
> -#include <linux/mutex.h>
> -#include <linux/delay.h>
>  
> +#include <linux/iio/buffer.h>
> +#include <linux/iio/events.h>
>  #include <linux/iio/iio.h>
> -#include <linux/iio/types.h>
>  #include <linux/iio/sysfs.h>
> -#include <linux/iio/events.h>
> -#include <linux/iio/buffer.h>
> -#include <linux/iio/triggered_buffer.h>
>  #include <linux/iio/trigger_consumer.h>
> +#include <linux/iio/triggered_buffer.h>
> +#include <linux/iio/types.h>

Small nit, but I'd drop iio/types.h as it is included by iio/iio.h
(No need to send a new version though, this can be addressed in the
future).

>  #define ADS1015_DRV_NAME "ads1015"
>  



-- 
Kind regards,
Joshua Crofts

  reply	other threads:[~2026-10-01  7:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 17:11 [PATCH v5 00/10] iio: adc: ti-ads1015: modernize resource management and bitfield logic Archit Anant
2026-09-30 17:11 ` [PATCH v5 01/10] iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS() Archit Anant
2026-09-30 17:11 ` [PATCH v5 02/10] iio: adc: ti-ads1015: sort headers alphabetically Archit Anant
2026-10-01  7:08   ` Joshua Crofts [this message]
2026-09-30 17:11 ` [PATCH v5 03/10] iio: adc: ti-ads1015: return -ENODATA when match data is missing Archit Anant
2026-09-30 17:11 ` [PATCH v5 04/10] iio: adc: ti-ads1015: use local device pointer in probe Archit Anant
2026-09-30 17:11 ` [PATCH v5 05/10] iio: adc: ti-ads1015: use dev_err_probe() for error handling Archit Anant
2026-10-01  7:10   ` Joshua Crofts
2026-09-30 17:12 ` [PATCH v5 06/10] iio: adc: ti-ads1015: drop unneeded < 0 error checks Archit Anant
2026-09-30 17:12 ` [PATCH v5 07/10] iio: adc: ti-ads1015: use devm_mutex_init() Archit Anant
2026-09-30 17:12 ` [PATCH v5 08/10] iio: adc: ti-ads1015: use managed runtime PM setup Archit Anant
2026-09-30 17:12 ` [PATCH v5 09/10] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Archit Anant
2026-09-30 17:12 ` [PATCH v5 10/10] iio: adc: ti-ads1015: replace custom shift macros with FIELD_PREP/GET Archit Anant
2026-10-01  7:12 ` [PATCH v5 00/10] iio: adc: ti-ads1015: modernize resource management and bitfield logic Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001090824.00002477@gmail.com \
    --to=joshua.crofts1@gmail.com \
    --cc=andy@kernel.org \
    --cc=architanant5@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®