From: Jakub Kicinski <kuba@kernel.org>
To: Weiming Shi <bestswngs@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
co+2cf741c3005abc20@bugs.sh, Xiang Mei <xmei5@asu.edu>
Subject: Re: [PATCH net v2 0/2] net: team: fix transmit skb ownership
Date: Thu, 1 Oct 2026 16:09:58 -0700 [thread overview]
Message-ID: <20261001160958.00a95918@kernel.org> (raw)
In-Reply-To: <20261001182326.572045-1-bestswngs@gmail.com>
On Fri, 2 Oct 2026 02:23:24 +0800 Weiming Shi wrote:
> The queue override path can pass an skb to a lower device, see that
> dev_queue_xmit() returned a drop, and then reuse the consumed skb. Fix
> the handoff decision separately from the transmit result.
>
> An AI-generated review of v1 forwarded by Jakub identified a separate
> broadcast-mode leak: bc_transmit() returns without consuming the skb
> when no port is txable. Fix that in the second patch.
Do not repost just for this but, please, DO NOT post new revisions in
reply to old ones.
See https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
--
pv-bot: threaded
prev parent reply other threads:[~2026-10-01 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:00 [PATCH net] net: team: stop reusing skb after queue override Weiming Shi
2026-09-30 6:04 ` Hangbin Liu
2026-09-30 23:39 ` Jakub Kicinski
2026-10-01 18:23 ` [PATCH net v2 0/2] net: team: fix transmit skb ownership Weiming Shi
2026-10-01 18:23 ` [PATCH net v2 1/2] net: team: stop reusing skb after queue override Weiming Shi
2026-10-01 18:23 ` [PATCH net v2 2/2] net: team: free skb when broadcast has no txable port Weiming Shi
2026-10-01 18:28 ` [PATCH net v2 0/2] net: team: fix transmit skb ownership netdev-bot+sinfo
2026-10-01 23:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001160958.00a95918@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bestswngs@gmail.com \
--cc=co+2cf741c3005abc20@bugs.sh \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®