From: Weiming Shi <bestswngs@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
co+2cf741c3005abc20@bugs.sh, Xiang Mei <xmei5@asu.edu>,
Weiming Shi <bestswngs@gmail.com>
Subject: [PATCH net v2 0/2] net: team: fix transmit skb ownership
Date: Fri, 2 Oct 2026 02:23:24 +0800 [thread overview]
Message-ID: <20261001182326.572045-1-bestswngs@gmail.com> (raw)
In-Reply-To: <20260926090039.1714460-1-bestswngs@gmail.com>
The queue override path can pass an skb to a lower device, see that
dev_queue_xmit() returned a drop, and then reuse the consumed skb. Fix
the handoff decision separately from the transmit result.
An AI-generated review of v1 forwarded by Jakub identified a separate
broadcast-mode leak: bc_transmit() returns without consuming the skb
when no port is txable. Fix that in the second patch.
v1: https://lore.kernel.org/r/20260926090039.1714460-1-bestswngs@gmail.com
Changes since v1:
- Use list_first_or_null_rcu() in the queue override helper, as Hangbin
suggested, since only one override port can receive the skb.
- Add a separate broadcast-mode fix for the no-port skb leak raised in
the AI-generated review forwarded by Jakub.
Weiming Shi (2):
net: team: stop reusing skb after queue override
net: team: free skb when broadcast has no txable port
drivers/net/team/team_core.c | 16 ++++++++--------
drivers/net/team/team_mode_broadcast.c | 2 ++
2 files changed, 10 insertions(+), 8 deletions(-)
--
2.55.0
next prev parent reply other threads:[~2026-10-01 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:00 [PATCH net] net: team: stop reusing skb after queue override Weiming Shi
2026-09-30 6:04 ` Hangbin Liu
2026-09-30 23:39 ` Jakub Kicinski
2026-10-01 18:23 ` Weiming Shi [this message]
2026-10-01 18:23 ` [PATCH net v2 1/2] " Weiming Shi
2026-10-01 18:23 ` [PATCH net v2 2/2] net: team: free skb when broadcast has no txable port Weiming Shi
2026-10-01 18:28 ` [PATCH net v2 0/2] net: team: fix transmit skb ownership netdev-bot+sinfo
2026-10-01 23:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001182326.572045-1-bestswngs@gmail.com \
--to=bestswngs@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=co+2cf741c3005abc20@bugs.sh \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®