From: Greg KH <gregkh@linuxfoundation.org>
To: Balazs Moro <balazs.moro@proton.me>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unused NDIS definitions
Date: Thu, 1 Oct 2026 07:40:37 +0200 [thread overview]
Message-ID: <2026100129-mulch-autograph-b148@gregkh> (raw)
In-Reply-To: <20260909195344.353880-1-balazs.moro@proton.me>
On Wed, Sep 09, 2026 at 07:54:13PM +0000, Balazs Moro wrote:
> NDIS_802_11_RATES has had no users since the driver was added.
> NDIS_802_11_PMKID_VALUE became unused when struct BSSIDInfo was
> removed.
>
> Remove the unused typedefs and NDIS_802_11_LENGTH_RATES, which was
> only used by NDIS_802_11_RATES.
>
> Signed-off-by: Balazs Moro <balazs.moro@proton.me>
> ---
> drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 --
> drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> index 768e4868ecfd..020b143f36be 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> @@ -7,8 +7,6 @@
> #ifndef __RTW_IOCTL_SET_H_
> #define __RTW_IOCTL_SET_H_
>
> -typedef u8 NDIS_802_11_PMKID_VALUE[16];
> -
> u8 rtw_set_802_11_authentication_mode(struct adapter *pdapter, enum ndis_802_11_authentication_mode authmode);
> u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep);
> u8 rtw_set_802_11_disassociate(struct adapter *padapter);
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index f4c1456f1476..ff2cee2f3b99 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -12,10 +12,8 @@
>
>
> #define NDIS_802_11_LENGTH_SSID 32
> -#define NDIS_802_11_LENGTH_RATES 8
> #define NDIS_802_11_LENGTH_RATES_EX 16
>
> -typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* Set of 8 data rates */
> typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */
>
> struct ndis_802_11_ssid {
> --
> 2.47.3
>
>
>
Does not apply to the staging-testing tree :(
prev parent reply other threads:[~2026-10-01 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 19:54 Balazs Moro
2026-10-01 5:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100129-mulch-autograph-b148@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=balazs.moro@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®