[PATCH] staging: rtl8723bs: remove unused NDIS definitions

[PATCH] staging: rtl8723bs: remove unused NDIS definitions

[Balazs Moro]

NDIS_802_11_RATES has had no users since the driver was added.
NDIS_802_11_PMKID_VALUE became unused when struct BSSIDInfo was
removed.

Remove the unused typedefs and NDIS_802_11_LENGTH_RATES, which was
only used by NDIS_802_11_RATES.

Signed-off-by: Balazs Moro <balazs.moro@proton.me>
---
 drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 --
 drivers/staging/rtl8723bs/include/wlan_bssdef.h   | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
index 768e4868ecfd..020b143f36be 100644
--- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
+++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
@@ -7,8 +7,6 @@
 #ifndef __RTW_IOCTL_SET_H_
 #define __RTW_IOCTL_SET_H_
 
-typedef u8 NDIS_802_11_PMKID_VALUE[16];
-
 u8 rtw_set_802_11_authentication_mode(struct adapter *pdapter, enum ndis_802_11_authentication_mode authmode);
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep);
 u8 rtw_set_802_11_disassociate(struct adapter *padapter);
diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
index f4c1456f1476..ff2cee2f3b99 100644
--- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
+++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
@@ -12,10 +12,8 @@
 
 
 #define NDIS_802_11_LENGTH_SSID         32
-#define NDIS_802_11_LENGTH_RATES        8
 #define NDIS_802_11_LENGTH_RATES_EX     16
 
-typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
 typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
 
 struct ndis_802_11_ssid {
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: remove unused NDIS definitions

[Greg KH]

On Wed, Sep 09, 2026 at 07:54:13PM +0000, Balazs Moro wrote:
> NDIS_802_11_RATES has had no users since the driver was added.
> NDIS_802_11_PMKID_VALUE became unused when struct BSSIDInfo was
> removed.
> 
> Remove the unused typedefs and NDIS_802_11_LENGTH_RATES, which was
> only used by NDIS_802_11_RATES.
> 
> Signed-off-by: Balazs Moro <balazs.moro@proton.me>
> ---
>  drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 --
>  drivers/staging/rtl8723bs/include/wlan_bssdef.h   | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> index 768e4868ecfd..020b143f36be 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> @@ -7,8 +7,6 @@
>  #ifndef __RTW_IOCTL_SET_H_
>  #define __RTW_IOCTL_SET_H_
>  
> -typedef u8 NDIS_802_11_PMKID_VALUE[16];
> -
>  u8 rtw_set_802_11_authentication_mode(struct adapter *pdapter, enum ndis_802_11_authentication_mode authmode);
>  u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep);
>  u8 rtw_set_802_11_disassociate(struct adapter *padapter);
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index f4c1456f1476..ff2cee2f3b99 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -12,10 +12,8 @@
>  
>  
>  #define NDIS_802_11_LENGTH_SSID         32
> -#define NDIS_802_11_LENGTH_RATES        8
>  #define NDIS_802_11_LENGTH_RATES_EX     16
>  
> -typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
>  typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
>  
>  struct ndis_802_11_ssid {
> -- 
> 2.47.3
> 
> 
> 

Does not apply to the staging-testing tree :(