[PATCH] staging: rtl8723bs : remove dead commented-out 8192e code

[PATCH] staging: rtl8723bs : remove dead commented-out 8192e code

[Timo Joannin]

The rtl8723bs_hal_init.c file contains a commented-out
call to rtw_write(8) referencing REG_DWBCN1_CTRL_8192E.

A grep of the driver in the rtl8723bs codebase shows that
REG_DWBCN1_CTRL_8192E isn't defined anywhere else,
meaning it could never be uncommented without breaking the build.
Remove it to clean up the driver.

Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 6a4a13544ca1..748567059af8 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1903,7 +1903,6 @@ static void hw_var_set_opmode(struct adapter *padapter, u8 variable, u8 *val)
 			rtw_write8(padapter, REG_BCN_CTRL, (DIS_TSF_UDT|EN_BCN_FUNCTION|EN_TXBCN_RPT|DIS_BCNQ_SUB));
 
 			/* SW_BCN_SEL - Port0 */
-			/* rtw_write8(Adapter, REG_DWBCN1_CTRL_8192E+2, rtw_read8(Adapter, REG_DWBCN1_CTRL_8192E+2) & ~BIT4); */
 			rtw_hal_set_hwreg(padapter, HW_VAR_DL_BCN_SEL, NULL);
 
 			/*  select BCN on port 0 */
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs : remove dead commented-out 8192e code

[Greg KH]

On Tue, Sep 29, 2026 at 03:07:16PM +0200, Timo Joannin wrote:
> The rtl8723bs_hal_init.c file contains a commented-out
> call to rtw_write(8) referencing REG_DWBCN1_CTRL_8192E.
> 
> A grep of the driver in the rtl8723bs codebase shows that
> REG_DWBCN1_CTRL_8192E isn't defined anywhere else,
> meaning it could never be uncommented without breaking the build.
> Remove it to clean up the driver.
> 
> Signed-off-by: Timo Joannin <timo.joannin@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index 6a4a13544ca1..748567059af8 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -1903,7 +1903,6 @@ static void hw_var_set_opmode(struct adapter *padapter, u8 variable, u8 *val)
>  			rtw_write8(padapter, REG_BCN_CTRL, (DIS_TSF_UDT|EN_BCN_FUNCTION|EN_TXBCN_RPT|DIS_BCNQ_SUB));
>  
>  			/* SW_BCN_SEL - Port0 */
> -			/* rtw_write8(Adapter, REG_DWBCN1_CTRL_8192E+2, rtw_read8(Adapter, REG_DWBCN1_CTRL_8192E+2) & ~BIT4); */
>  			rtw_hal_set_hwreg(padapter, HW_VAR_DL_BCN_SEL, NULL);
>  
>  			/*  select BCN on port 0 */
> -- 
> 2.55.0
> 

Someone already sent this change before you did, sorry.

thanks,

greg k-h