mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eduard Zateev <hackerowskiy@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unused variable 'phal'
Date: Thu, 1 Oct 2026 11:24:55 +0200	[thread overview]
Message-ID: <2026100151-winking-boss-9194@gregkh> (raw)
In-Reply-To: <20260923010423.6352-1-hackerowskiy@gmail.com>

On Wed, Sep 23, 2026 at 03:04:23AM +0200, Eduard Zateev wrote:
> phal is assigned but never used in rtl8723bs_init_xmit_priv(),
> which triggers a -Wunused-but-set-variable warning with W=1.
> Remove the unused variable and its assignment.
> 
> Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7f55448d544e..0441e84ea87d 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -525,9 +525,6 @@ s32	rtl8723bs_hal_xmitframe_enqueue(
>  s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
>  {
>  	struct xmit_priv *xmitpriv = &padapter->xmitpriv;
> -	struct hal_com_data *phal;
> -
> -	phal = GET_HAL_DATA(padapter);
>  
>  	init_completion(&xmitpriv->SdioXmitStart);
>  	init_completion(&xmitpriv->SdioXmitTerminate);
> -- 
> 2.55.0
> 
> 

Does not apply to the tree :(

  reply	other threads:[~2026-10-01  9:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  1:04 Eduard Zateev
2026-10-01  9:24 ` Greg Kroah-Hartman [this message]
2026-09-24 18:53 George Karagounis
2026-10-01  9:25 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100151-winking-boss-9194@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=hackerowskiy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®