* [PATCH] staging: rtl8723bs: remove unused variable 'phal'
@ 2026-09-23 1:04 Eduard Zateev
2026-10-01 9:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Eduard Zateev @ 2026-09-23 1:04 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Eduard Zateev
phal is assigned but never used in rtl8723bs_init_xmit_priv(),
which triggers a -Wunused-but-set-variable warning with W=1.
Remove the unused variable and its assignment.
Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 7f55448d544e..0441e84ea87d 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -525,9 +525,6 @@ s32 rtl8723bs_hal_xmitframe_enqueue(
s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
{
struct xmit_priv *xmitpriv = &padapter->xmitpriv;
- struct hal_com_data *phal;
-
- phal = GET_HAL_DATA(padapter);
init_completion(&xmitpriv->SdioXmitStart);
init_completion(&xmitpriv->SdioXmitTerminate);
--
2.55.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unused variable 'phal'
2026-09-23 1:04 [PATCH] staging: rtl8723bs: remove unused variable 'phal' Eduard Zateev
@ 2026-10-01 9:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-01 9:24 UTC (permalink / raw)
To: Eduard Zateev; +Cc: linux-staging, linux-kernel
On Wed, Sep 23, 2026 at 03:04:23AM +0200, Eduard Zateev wrote:
> phal is assigned but never used in rtl8723bs_init_xmit_priv(),
> which triggers a -Wunused-but-set-variable warning with W=1.
> Remove the unused variable and its assignment.
>
> Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7f55448d544e..0441e84ea87d 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -525,9 +525,6 @@ s32 rtl8723bs_hal_xmitframe_enqueue(
> s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
> {
> struct xmit_priv *xmitpriv = &padapter->xmitpriv;
> - struct hal_com_data *phal;
> -
> - phal = GET_HAL_DATA(padapter);
>
> init_completion(&xmitpriv->SdioXmitStart);
> init_completion(&xmitpriv->SdioXmitTerminate);
> --
> 2.55.0
>
>
Does not apply to the tree :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unused variable 'phal'
2026-09-24 18:53 George Karagounis
@ 2026-10-01 9:25 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-01 9:25 UTC (permalink / raw)
To: George Karagounis; +Cc: linux-staging, linux-kernel, mail
On Thu, Sep 24, 2026 at 09:53:49PM +0300, George Karagounis wrote:
> In rtl8723bs_init_xmit_priv() the variable 'phal' is assigned via
> GET_HAL_DATA() but never actually read.
>
> This triggers a -Wunused-but-set-variable compiler warning when
> building the driver with W=1. I removed the unused variable and its
> assignment to clean up the code and silence the warning.
>
> Signed-off-by: George Karagounis <mail@taterr.org>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7f55448d544e..0441e84ea87d 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -525,9 +525,6 @@ s32 rtl8723bs_hal_xmitframe_enqueue(
> s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
> {
> struct xmit_priv *xmitpriv = &padapter->xmitpriv;
> - struct hal_com_data *phal;
> -
> - phal = GET_HAL_DATA(padapter);
>
> init_completion(&xmitpriv->SdioXmitStart);
> init_completion(&xmitpriv->SdioXmitTerminate);
> --
> 2.55.0
>
Does not apply to the tree as it's been sent many times in the past and
already applied.
Did everyone just go through some tutorial and decide to send the same
change?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: rtl8723bs: remove unused variable 'phal'
@ 2026-09-24 18:53 George Karagounis
2026-10-01 9:25 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: George Karagounis @ 2026-09-24 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, mail
In rtl8723bs_init_xmit_priv() the variable 'phal' is assigned via
GET_HAL_DATA() but never actually read.
This triggers a -Wunused-but-set-variable compiler warning when
building the driver with W=1. I removed the unused variable and its
assignment to clean up the code and silence the warning.
Signed-off-by: George Karagounis <mail@taterr.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 7f55448d544e..0441e84ea87d 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -525,9 +525,6 @@ s32 rtl8723bs_hal_xmitframe_enqueue(
s32 rtl8723bs_init_xmit_priv(struct adapter *padapter)
{
struct xmit_priv *xmitpriv = &padapter->xmitpriv;
- struct hal_com_data *phal;
-
- phal = GET_HAL_DATA(padapter);
init_completion(&xmitpriv->SdioXmitStart);
init_completion(&xmitpriv->SdioXmitTerminate);
--
2.55.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-01 9:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23 1:04 [PATCH] staging: rtl8723bs: remove unused variable 'phal' Eduard Zateev
2026-10-01 9:24 ` Greg Kroah-Hartman
2026-09-24 18:53 George Karagounis
2026-10-01 9:25 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®