* [PATCH] rtl8723bs: return bool from check_pending_xmitbuf
@ 2026-09-19 16:38 Matheus Alves de Almeida
2026-10-01 5:51 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Matheus Alves de Almeida @ 2026-09-19 16:38 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Matheus Alves de Almeida
check_pending_xmitbuf() returns only true or false. Use bool as its
return type to accurately describe the function's behavior.
Signed-off-by: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 95350fd6a94fc..634320e53aabe 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2469,10 +2469,10 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
return pxmitbuf;
}
-signed int check_pending_xmitbuf(struct xmit_priv *pxmitpriv)
+bool check_pending_xmitbuf(struct xmit_priv *pxmitpriv)
{
struct __queue *pqueue;
- signed int ret = false;
+ bool ret = false;
pqueue = &pxmitpriv->pending_xmitbuf_queue;
diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h
index 873807fcd0dd0..7d429300323f9 100644
--- a/drivers/staging/rtl8723bs/include/rtw_xmit.h
+++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h
@@ -456,7 +456,7 @@ void enqueue_pending_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmit
void enqueue_pending_xmitbuf_to_head(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf);
struct xmit_buf *dequeue_pending_xmitbuf(struct xmit_priv *pxmitpriv);
struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpriv);
-signed int check_pending_xmitbuf(struct xmit_priv *pxmitpriv);
+bool check_pending_xmitbuf(struct xmit_priv *pxmitpriv);
int rtw_xmit_thread(void *context);
u32 rtw_get_ff_hwaddr(struct xmit_frame *pxmitframe);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] rtl8723bs: return bool from check_pending_xmitbuf
2026-09-19 16:38 [PATCH] rtl8723bs: return bool from check_pending_xmitbuf Matheus Alves de Almeida
@ 2026-10-01 5:51 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-01 5:51 UTC (permalink / raw)
To: Matheus Alves de Almeida; +Cc: linux-staging, linux-kernel
On Sat, Sep 19, 2026 at 01:38:57PM -0300, Matheus Alves de Almeida wrote:
> check_pending_xmitbuf() returns only true or false. Use bool as its
> return type to accurately describe the function's behavior.
>
> Signed-off-by: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
> drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Shouldn't there be a "staging" in the subject line?
And why not also change the place where this is called?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-01 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 16:38 [PATCH] rtl8723bs: return bool from check_pending_xmitbuf Matheus Alves de Almeida
2026-10-01 5:51 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®