* [PATCH] media: i2c: imx471: Fix register size for IMX471_REG_DPGA_USE_GLOBAL_GAIN
@ 2026-10-02 5:11 Kate Hsuan
0 siblings, 0 replies; only message in thread
From: Kate Hsuan @ 2026-10-02 5:11 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Hans de Goede, Sakari Ailus
Cc: linux-media, linux-kernel, Kate Hsuan
The IMX471_REG_DPGA_USE_GLOBAL_GAIN register was incorrectly defined as a
16-bit register, preventing global gain from enabling correctly. As a
result, only the green channel gain was applied instead of the intended
global gain.
Change the register size to 8 bits to ensure global gain is properly
enabled.
Link: https://lore.kernel.org/linux-media/35240e45-c73b-4425-923a-c1026386ed3c@slotpi17m12/
Fixes: be1589e567ae ("media: i2c: imx471: Add Sony IMX471 image sensor driver")
Signed-off-by: Kate Hsuan <hpa@redhat.com>
---
drivers/media/i2c/imx471.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c
index 4053aed84340..b442b083286d 100644
--- a/drivers/media/i2c/imx471.c
+++ b/drivers/media/i2c/imx471.c
@@ -46,7 +46,7 @@
#define IMX471_ANA_GAIN_DEFAULT 0
/* Digital gain control */
-#define IMX471_REG_DPGA_USE_GLOBAL_GAIN CCI_REG16(0x3ff9)
+#define IMX471_REG_DPGA_USE_GLOBAL_GAIN CCI_REG8(0x3ff9)
#define IMX471_REG_DIG_GAIN_GLOBAL CCI_REG16(0x020e)
#define IMX471_DGTL_GAIN_MIN 256
#define IMX471_DGTL_GAIN_MAX 4095
--
2.55.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-02 5:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-02 5:11 [PATCH] media: i2c: imx471: Fix register size for IMX471_REG_DPGA_USE_GLOBAL_GAIN Kate Hsuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®